From dev-return-104724-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Jun 4 22:11:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6138A18064D for ; Wed, 5 Jun 2019 00:11:12 +0200 (CEST) Received: (qmail 96939 invoked by uid 500); 4 Jun 2019 22:11:08 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 96857 invoked by uid 99); 4 Jun 2019 22:11:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2019 22:11:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 42D371812EE for ; Tue, 4 Jun 2019 22:11:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ipwBueijua7B for ; Tue, 4 Jun 2019 22:11:04 +0000 (UTC) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B3C1B5F6C3 for ; Tue, 4 Jun 2019 22:11:03 +0000 (UTC) Received: by mail-oi1-f177.google.com with SMTP id 203so16761307oid.13 for ; Tue, 04 Jun 2019 15:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=NSlcKxpW6+Kl6JI76MzbBH9lBmwA/3yGOvsk2bM0MP0=; b=PjN2R17Pe03gOFEmh3Ig6ZuWijD3pG6aMMYw4wCuJHfUhZXzsLEwO6TIJTSi6z1IE4 bGbcvmxIdwQY1WgMVegGSlFAu1HLxsvI+uapjv4IG70JvpDvJet10rQbtAT6mFa1iuwV 3xMbreoP/n4hNrieRVufERW45U+LbgEwZLjNnWtFYvzh7OjJvLexKZ32Pcr5QnCJrYtG pIFKreuqxKv5M8MWvm71bLXVGJ+FII62kMOMRNhc14ePQms31m+Qa3QPIjhfCKQN+WIF DRLNl29oJ3pYUy/v6H/Sik6TFXRNiNZeO6OsYx/U8TLXlPX8BKDZ+OL+2F5rBlmpFJaF EuOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=NSlcKxpW6+Kl6JI76MzbBH9lBmwA/3yGOvsk2bM0MP0=; b=my4YfU9vU/bq1ZorTfCiHmSCZJ3e96ckfpf18rvTuze0KIMv3dEwfTjwTxW/fFmitF T7bJR+Tj9F0CabWej2LByGL6OF9UFuGRFuldsze7sERr0OTOYGNqP59NSIx5VxpxiLIw a/62E6kM9kHIguVKOXtuzkr8M7JjH+RPdBt7rvyZFb426Ktv8HAQh4ooTKolfZJXwojw uBy1S+OmB2KFp44KKILngGGifhbYE4EGz44Pb5aj4eSyUH8/0IiJK1i2EuEms/iZczAM XtJzwlEfrckzD+O9AR9ADXw5H/3gflv7s4Q9vc1y/xoiXtPB/HgoEREkmWJ0uchp9ccm aR7A== X-Gm-Message-State: APjAAAVfh9Vxa0YktbjYWVEuVlM0xk0mchfNccOuXJzWnnk1QMw9M637 5QgYYFLs900A22Dpj5moXQfUSNvsvzjcsZs0uIA1ckqtn+8= X-Google-Smtp-Source: APXvYqxigic0mZmdsVRZeoCVzRFQYPuRTwkuUKFjlw2OFjuClvOTooNHdkC1XYhR9ThiPF7KPp65HOADmD9CGXv2sDg= X-Received: by 2002:aca:3047:: with SMTP id w68mr5743138oiw.71.1559686255360; Tue, 04 Jun 2019 15:10:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jose Armando Garcia Sancio Date: Tue, 4 Jun 2019 15:10:44 -0700 Message-ID: Subject: Re: [VOTE] KIP-460: Admin Leader Election RPC To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="00000000000036618c058a86c197" --00000000000036618c058a86c197 Content-Type: text/plain; charset="UTF-8" Hi all, During the implementation of KIP-460, we discovered that we had to make some minor changes to the design. I have updated the KIP wiki[1]. You can see the difference here[2]. At a high-level we made the following changes: 1. Added a top level ErrorCode to the response for errors that apply to all of the topic partitions. This is currently being used for cluster authorization errors. 2. We renamed the delayedOperation for DelayOperationPurgatory from ElectPreferredLeader to ElectLeader. [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC . [2] https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=113707931&selectedPageVersions=19&selectedPageVersions=18 On Tue, May 7, 2019 at 9:59 AM Jose Armando Garcia Sancio < jsancio@confluent.io> wrote: > Thanks Gwen for the clarification! > > On Mon, May 6, 2019 at 5:03 PM Gwen Shapira wrote: > >> All committer votes are binding, so you have binding +1 from Colin, Jason >> and myself - which is just the 3 you need for the KIP to be accepted. >> Mickael added non-binding community support, which is great signal as >> well. >> >> On Mon, May 6, 2019 at 4:39 PM Jose Armando Garcia Sancio < >> jsancio@confluent.io> wrote: >> >> > I am closing the voting. KIP is accepted with: >> > >> > +1 (binding): Colin McCabe >> > +1 (non-binding): Jason Gustafson, Gwen Shapira, Mickael Maison >> > >> > Thanks! >> > >> > On Fri, May 3, 2019 at 9:59 AM Mickael Maison > > >> > wrote: >> > >> > > +1 (non binding) >> > > Thanks for the KIP >> > > >> > > On Thu, May 2, 2019 at 11:02 PM Colin McCabe >> wrote: >> > > > >> > > > +1 (binding) >> > > > >> > > > thanks, Jose. >> > > > >> > > > best, >> > > > Colin >> > > > >> > > > On Wed, May 1, 2019, at 14:44, Jose Armando Garcia Sancio wrote: >> > > > > Hi all, >> > > > > >> > > > > I would like to start the voting for KIP-460: >> > > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC >> > > > > >> > > > > The thread discussion is here: >> > > > > https://www.mail-archive.com/dev@kafka.apache.org/msg97226.html >> > > > > >> > > > > Thanks! >> > > > > -Jose >> > > > > >> > > >> > >> > >> > -- >> > -Jose >> > >> >> >> -- >> *Gwen Shapira* >> Product Manager | Confluent >> 650.450.2760 | @gwenshap >> Follow us: Twitter | blog >> >> > > > -- > -Jose > -- -Jose --00000000000036618c058a86c197--