From dev-return-103865-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Mon May 6 18:59:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BB19818060F for ; Mon, 6 May 2019 20:59:01 +0200 (CEST) Received: (qmail 71188 invoked by uid 500); 6 May 2019 18:58:59 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 71176 invoked by uid 99); 6 May 2019 18:58:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 May 2019 18:58:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B97CEC6A49 for ; Mon, 6 May 2019 18:58:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, WEIRD_PORT=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id IqIv_SdzjoZV for ; Mon, 6 May 2019 18:58:55 +0000 (UTC) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 112885F118 for ; Mon, 6 May 2019 18:58:55 +0000 (UTC) Received: by mail-lj1-f169.google.com with SMTP id z5so6936232lji.10 for ; Mon, 06 May 2019 11:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Hd+3cdfdVnTLhWqPvbf2vk6kSkeIBSUzNDYNUSaFaw4=; b=RBF6ShHc6NaOLrhPQms6XbiNSD+RaQ0ghgktrQko8A4HygoihARixVHELFHR7ykMHF /d77yvsvLxF+AUh4Mz+PodLdzqpAXvNSad5C12vQ0344NAgB/LVkjiDVjdzG4cPnJerk bWMJeDQ8GbktHSGqdMmDD1lUd3HvnvRnXJEWK1AsqrsYJzm39tv8qQa9j1N9qYLLqZ7D 7PMNPrzh2Xtnqeu7jBIp5uEhBPAEUS9iytigcaROIT1Hvo2QfiZ6cbfVFrLK/hsZsBqt gKbKcy5J1+SOLeBJLEAbAbtj9Q8DXqKFhI6Aipyd9e1hhvxYm2yzpkSq3uUzp9xnv5zz GrMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Hd+3cdfdVnTLhWqPvbf2vk6kSkeIBSUzNDYNUSaFaw4=; b=hGY4y/S3ehTn7+Y7upmR6SPbawlye8fH4uNXueedsK37L+XUBsyqjhvpuZrtHgkMu9 HeCOn6a1jryv1NHtt6zRYseVL62CGufs3TW1nee9Ny36WJCvGs2exVrxi2iE27pH1YxH Bm24tKJAq99UGHpzg2zFJ4j9jNzGB6AMHOoib4buYMpcEe2wOUEyk6SFVbJMHExcvyiU by2DbmCx3NfGIxHzd2ZuJue+B1lFgLTIHrWQ8qbe5kMrHFbIwjdpakR4wxhvLYQXtBWZ lNBjFVocwQ5GiKt+mYErrEfUD81t4kwcbBcXisx4xn96/A86KXXFqLY3EXNRU+4C5hrx 9HUw== X-Gm-Message-State: APjAAAWOUr81ofp1pX1hIISmDQXFS8tRVUHZD8jlmKSzs6yUPBfUXxQ6 obXSThGyXrR4B/egdf4nBgED8RZaOJv/d+5kl0IzfTl2 X-Google-Smtp-Source: APXvYqxyurhJibXeCPuiutBddQ+w4on7Ugcbl4xCOLEZojzclJq0Fm2jX8upvmGDC+W9SzUZ1kdadAYJ3G5alga6jRc= X-Received: by 2002:a2e:7308:: with SMTP id o8mr14113320ljc.171.1557169133441; Mon, 06 May 2019 11:58:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Konstantine Karantasis Date: Mon, 6 May 2019 11:58:42 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-465: Add Consolidated Connector Endpoint to Connect REST API To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="0000000000000ded1a05883cb1df" --0000000000000ded1a05883cb1df Content-Type: text/plain; charset="UTF-8" This is a nice improvement, both from an operational standpoint as well as for testing purposes, as we scale the number of connectors that a connect cluster can run. LGTM, thanks for the KIP Dan! On Fri, May 3, 2019 at 2:50 PM Alex Liu wrote: > Good question, > > `info` is probably the best name for it. The updated output on the wiki > looks reasonable to me. > > Alex > > On Fri, May 3, 2019 at 2:24 PM dan wrote: > > > thanks. i think this make sense. > > > > i'm thinking we should just use repeated queryparams for this, so > > `?expand=status&expand=config` > > > > another thing is what do you think we should use for the `/` endpoint? > was > > thinking `?expand=info` > > > > output could look like > > > > w:kafka norwood$ curl -s ' > > http://localhost:8083/connectors?expand=status&expand=config' | jq > > > > { > > > > "blah": { > > > > "config": { > > > > "name": "blah", > > > > "config": { > > > > "connector.class": > > "org.apache.kafka.connect.file.FileStreamSourceConnector", > > > > "file": "/tmp/lol", > > > > "tasks.max": "10", > > > > "name": "blah", > > > > "topic": "test-topic" > > > > }, > > > > "tasks": [ > > > > { > > > > "connector": "blah", > > > > "task": 0 > > > > } > > > > ], > > > > "type": "source" > > > > }, > > > > "status": { > > > > "name": "blah", > > > > "connector": { > > > > "state": "RUNNING", > > > > "worker_id": "10.200.25.241:8083" > > > > }, > > > > "tasks": [ > > > > { > > > > "id": 0, > > > > "state": "RUNNING", > > > > "worker_id": "10.200.25.241:8083" > > > > } > > > > ], > > > > "type": "source" > > > > } > > > > } > > > > } > > > > > > will update the wiki with this info > > > > thanks > > dan > > > > On Thu, May 2, 2019 at 4:43 PM Alex Liu wrote: > > > > > Good idea, Dan. One thing I might suggest is to have the query > parameters > > > reflect the fact that there are multiple resources under each > connector. > > > There is `connectors//`, `connectors//config`, and > > > `connectors//status`. > > > Each of them returns a slightly different set of information, so it > would > > > be useful to allow the query parameter be a string instead of a > > true/false > > > flag. In this case, `expand=status,config` would specify expanding both > > the > > > /status and /config subresources into the response objects. > > > > > > Other than this detail, I think this is a useful addition to the > Connect > > > REST API. > > > > > > Alex > > > > > > --0000000000000ded1a05883cb1df--