kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax" <matth...@confluent.io>
Subject Re: [DISCUSS] KIP-456: Helper classes to make it simpler to write test logic with TopologyTestDriver
Date Tue, 30 Apr 2019 10:59:20 GMT
KIP-451 was discarded in favor this this KIP. So it seems we are all on
the same page.


>> Relating to KIP-448.
>> What kind of alignment did you think about?

Nothing in particular. Was more or less a random though. Maybe there is
nothing to be aligned. Just wanted to bring it up. :)


>> Some thoughts after reading also the comments in KAFKA-6460:
>> To my understand these KIP-448 mock classes need to be fed somehow into
>> TopologyTestDriver.
>> I don't know how those KIP-448 mock are planned to be set to
>> TopologyTestDriver.

KIP-448 is still quite early, and it's a little unclear... Maybe we
should just ignore it for now. Sorry for the distraction with my comment
about it.


Please give me some more time to review this KIP in detail and I will
follow up later again.


-Matthias

On 4/26/19 2:25 PM, Jukka Karvanen wrote:
> Yes, my understanding was also that this KIP cover all the requirement of
> KIP-451.
> 
> Relating to KIP-448.
> What kind of alignment did you think about?
> 
> Some thoughts after reading also the comments in KAFKA-6460:
> To my understand these KIP-448 mock classes need to be fed somehow into
> TopologyTestDriver.
> I don't know how those KIP-448 mock are planned to be set to
> TopologyTestDriver.
> 
> On contrast KIP-456 was planned to be on top of unmodified
> TopologyTestDriver and now driver is set to TestInputTopic and
> TestOutputTopic in constructor.
> There are also alternative that these Topic object could be get from
> TopologyTestDriver, but it would require the duplicating the constructors
> of Topics as methods to
> TopologyTestDriver.
> 
> Also related to those Store object when going through the methods in
> TopologyTestDriver I noticed accessing the state stores could be be the
> third candidate for helper class or a group of classes.
> So addition to have TestInputTopic and TestOutputTopic, it could be also
> TestKeyValueStore, TestWindowStore, ... to follow the logic in this
> KPI-456, but
> it does add not any functionality on top of .already existing functionality
> *Store classes. So that's why I did not include those.
> 
> Jukka
> -
> 
> 
> 
> 
> 
> Not
> 
> pe 26. huhtik. 2019 klo 12.03 Matthias J. Sax (matthias@confluent.io)
> kirjoitti:
> 
>> Btw: there is also KIP-448. I was wondering if it might be required or
>> helpful to align the design of both with each other. Thoughts?
>>
>>
>>
>> On 4/25/19 11:22 PM, Matthias J. Sax wrote:
>>> Thanks for the KIP!
>>>
>>> I was just comparing this KIP with KIP-451 (even if I did not yet make a
>>> sorrow read over this KIP), and I agree that there is a big overlap. It
>>> seems that KIP-456 might subsume KIP-451.
>>>
>>> Let's wait on Patrick's input to see how to proceed.
>>>
>>>
>>> -Matthias
>>>
>>> On 4/25/19 12:03 AM, Jukka Karvanen wrote:
>>>> Hi,
>>>>
>>>> If you want to see or test the my current idea of the implementation of
>>>> this KIP, you can check it out in my repo:
>>>>
>> https://github.com/jukkakarvanen/kafka/compare/trunk...jukkakarvanen:KAFKA-8233_InputOutputTopics
>>>>
>>>>
>>>> After my test with KPI-451  I do not see need for add methods for
>>>> Iterables, but waiting Patrick's clarification of the use case.
>>>>
>>>> Jukka
>>>>
>>>>
>>>> ti 23. huhtik. 2019 klo 15.37 Jukka Karvanen (
>> jukka.karvanen@jukinimi.com)
>>>> kirjoitti:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I would like to start the discussion on KIP-456: Helper classes to
>> make it
>>>>> simpler to write test logic with TopologyTestDriver:
>>>>>
>>>>>
>>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-456%3A+Helper+classes+to+make+it+simpler+to+write+test+logic+with+TopologyTestDriver
>>>>>
>>>>>
>>>>> There is also related KIP adding methods to TopologyTestDriver:
>>>>>
>>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-451%3A+Make+TopologyTestDriver+output+iterable
>>>>>
>>>>>
>>>>> I added those new Iterable based methods to this TestOutputTopic even
>> not
>>>>> tested those myself yet.
>>>>> So this version contains both my original List and Map based methods
>> and
>>>>> these new one.
>>>>> Based on the discussion some of these can be dropped, if those are
>> seen as
>>>>> redundant.
>>>>>
>>>>> Best Regards,
>>>>> Jukka
>>>>>
>>>>>
>>>>
>>>
>>
>>
> 


Mime
View raw message