kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randall Hauch <rha...@gmail.com>
Subject Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers
Date Mon, 22 Apr 2019 18:09:24 GMT
Konstantine raises a good point. Which `Headers` is being referenced in the
API? The Connect `org.apache.kafka.connect.header.Headers` would correspond
to what was already deserialized by the `HeaderConverter` or what will yet
be serialized by the `HeaderConverter`. Alternatively, the common `
org.apache.kafka.common.header.Headers` would correspond to the raw header
pairs from the underlying Kafka record.

So, we probably want to be a bit more specific, and also mention why. And
we probably want to mention the other approach in the rejected alternatives.

Best regards,

Randall

On Mon, Apr 22, 2019 at 11:59 AM Konstantine Karantasis <
konstantine@confluent.io> wrote:

> Thanks for the KIP Yaroslav!
>
> Apologies for the late comment. However, after reading the KIP it's still
> not very clear to me what happens to the existing
> HeaderConverter interface and what's the expectation for existing code
> implementing this interface out there.
>
> Looking at the PR I see that the existing code is leaving the existing
> connect headers conversion unaffected. I'd expect by reading the KIP to
> understand what's the interplay of the current proposal with the existing
> implementation of KIP-145 that introduced headers in Connect.
>
> Thanks,
> Konstantine
>
> On Mon, Apr 22, 2019 at 9:07 AM Randall Hauch <rhauch@gmail.com> wrote:
>
> > Thanks for updating the KIP. It looks good to me, and since there haven't
> > been any other issue mentioned in this month-long thread, it's probably
> > fine to start a vote.
> >
> > Best regards,
> >
> > Randall
> >
> > On Tue, Apr 2, 2019 at 3:12 PM Randall Hauch <rhauch@gmail.com> wrote:
> >
> > > Thanks for the submission, Yaroslav -- and for building on the
> suggestion
> > > of Jeremy C in https://issues.apache.org/jira/browse/KAFKA-7273. This
> is
> > > a nice and simple approach that is backward compatible.
> > >
> > > The KIP looks good so far, but I do have two specific suggestions to
> make
> > > things just a bit more explicit. First, both the "Public API" and
> > "Proposed
> > > Changes" sections could be more explicit that the methods in the
> proposal
> > > are being added; as it's currently written a reader must infer that.
> > > Second, the "Proposed Changes" section needs to more clearly specify
> that
> > > the WorkerSourceTask will now use the new fromConnectData method with
> the
> > > headers instead of the existing method, and that the WorkerSinkTask
> will
> > > now use the toConnectData method with the headers instead of the
> existing
> > > method.
> > >
> > > Best regards,
> > >
> > > Randall
> > >
> > >
> > > On Mon, Mar 11, 2019 at 11:01 PM Yaroslav Tkachenko <
> sapiensy@gmail.com>
> > > wrote:
> > >
> > >> Hello,
> > >>
> > >> I'd like to propose a KIP that extends Kafka Connect Converter
> > interface:
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-440%3A+Extend+Connect+Converter+to+support+headers
> > >>
> > >> Thanks for considering!
> > >>
> > >> --
> > >> Yaroslav Tkachenko
> > >> sap1ens.com
> > >>
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message