kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yaodong Yang <yangyaodon...@gmail.com>
Subject Re: [DISCUSSION] KIP-422: Add support for user/client configuration in the Kafka Admin Client
Date Tue, 19 Feb 2019 23:20:47 GMT
Hello Jun, Viktor, Snoke and Stan,

Thanks for taking time to look at this KIP-422! For some reason, this email
was put in my spam folder. Sorry about that.

Jun is right, the main motivation for this KIP-422 is to allow users to
config user/clientId quota through AdminClient. In addition, this KIP-422
also allows users to set or update any config related to a user or clientId
entity if needed in the future.

For the KIP-257, I agree with Jun that we should add support for it. I will
look at the current implementation and update the KIP-422 with new change.

I will ping this thread once I updated the KIP.

Thanks again!
Yaodong

On Fri, Feb 15, 2019 at 1:28 AM Viktor Somogyi-Vass <viktorsomogyi@gmail.com>
wrote:

> Hi Guys,
>
> I wanted to reject that KIP, split it up and revamp it as in the meantime
> there were some overlapping works I just didn't get to it due to other
> higher priority work.
> One of the splitted KIPs would have been the quota part of that and I'd be
> happy if that lived in this KIP if Yaodong thinks it's worth to
> incorporate. I'd be also happy to rebase that wire protocol and contribute
> it to this KIP.
>
> Viktor
>
> On Wed, Feb 13, 2019 at 7:14 PM Jun Rao <jun@confluent.io> wrote:
>
> > Hi, Yaodong,
> >
> > Thanks for the KIP. As Stan mentioned earlier, it seems that this is
> > mostly covered by KIP-248, which was originally proposed by Victor.
> >
> > Hi, Victor,
> >
> > Do you still plan to work on KIP-248? It seems that you already got
> pretty
> > far on that. If not, would you mind letting Yaodong take over this?
> >
> > For both KIP-248 and KIP-422, one thing that I found missing is the
> > support for customized quota (
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-257+-+Configurable+Quota+Management
> ).
> > With KIP-257, it's possible for one to construct a customized quota
> defined
> > through a map of metric tags. It would be useful to support that in the
> > AdminClient API and the wire protocol.
> >
> > Hi, Sonke,
> >
> > I think the proposal is to support the user/clientId level quota through
> > an AdminClient api. The user can be obtained from any existing
> > authentication mechanisms.
> >
> > Thanks,
> >
> > Jun
> >
> > On Thu, Feb 7, 2019 at 5:59 AM Sönke Liebau
> > <soenke.liebau@opencore.com.invalid> wrote:
> >
> >> Hi Yaodong,
> >>
> >> thanks for the KIP!
> >>
> >> If I understand your intentions correctly then this KIP would only
> >> address a fairly specific use case, namely SASL-PLAIN with users
> >> defined in Zookeeper. For all other authentication mechanisms like
> >> SSL, SASL-GSSAPI or SASL-PLAIN with users defined in jaas files I
> >> don't see how the AdminClient could directly create new users.
> >> Is this correct, or am I missing something?
> >>
> >> Best regards,
> >> Sönke
> >>
> >> On Thu, Feb 7, 2019 at 2:47 PM Stanislav Kozlovski
> >> <stanislav@confluent.io> wrote:
> >> >
> >> > This KIP seems to duplicate some of the functionality proposed in
> >> KIP-248
> >> > <
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-248+-+Create+New+ConfigCommand+That+Uses+The+New+AdminClient
> >> >.
> >> > KIP-248 has been stuck in a vote thread since July 2018.
> >> >
> >> > Viktor, do you plan on working on the KIP?
> >> >
> >> > On Thu, Feb 7, 2019 at 1:27 PM Stanislav Kozlovski <
> >> stanislav@confluent.io>
> >> > wrote:
> >> >
> >> > > Hey there Yaodong, thanks for the KIP!
> >> > >
> >> > > I'm not too familiar with the user/client configurations we
> currently
> >> > > allow, is there a KIP describing the initial feature? If there is,
> it
> >> would
> >> > > be useful to include in KIP-422.
> >> > >
> >> > > I also didn't see any authorization in the PR, have we thought about
> >> > > needing to authorize the alter/describe requests per the
> user/client?
> >> > >
> >> > > Thanks,
> >> > > Stanislav
> >> > >
> >> > > On Fri, Jan 25, 2019 at 5:47 PM Yaodong Yang <
> yangyaodong88@gmail.com
> >> >
> >> > > wrote:
> >> > >
> >> > >> Hi folks,
> >> > >>
> >> > >> I've published KIP-422 which is about adding support for
> user/client
> >> > >> configurations in the Kafka Admin Client.
> >> > >>
> >> > >> Basically the story here is to allow KafkaAdminClient to configure
> >> the
> >> > >> user
> >> > >> or client configurations for users, instead of requiring users
to
> >> directly
> >> > >> talk to ZK.
> >> > >>
> >> > >> The link for this KIP is
> >> > >> following:
> >> > >>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=97555704
> >> > >>
> >> > >> I'd be happy to receive some feedback about the KIP I published.
> >> > >>
> >> > >> --
> >> > >> Best,
> >> > >> Yaodong Yang
> >> > >>
> >> > >
> >> > >
> >> > > --
> >> > > Best,
> >> > > Stanislav
> >> > >
> >> >
> >> >
> >> > --
> >> > Best,
> >> > Stanislav
> >>
> >>
> >>
> >> --
> >> Sönke Liebau
> >> Partner
> >> Tel. +49 179 7940878
> >> OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message