kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-7808) AdminClient#describeTopics should not throw InvalidTopicException if topic name is not found
Date Mon, 14 Jan 2019 17:17:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guozhang Wang resolved KAFKA-7808.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 2.2.0

> AdminClient#describeTopics should not throw InvalidTopicException if topic name is not
found
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-7808
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7808
>             Project: Kafka
>          Issue Type: Bug
>          Components: admin, core
>            Reporter: Guozhang Wang
>            Assignee: Lee Dongjin
>            Priority: Major
>             Fix For: 2.2.0
>
>
> In AdminClient#describeTopics, we have the following logic:
> {code:java}
>         if (!cluster.topics().contains(topicName)) {
>                         future.completeExceptionally(new InvalidTopicException("Topic
" + topicName + " not found."));
>                         continue;
>                     }
> {code}
> However, {{InvalidTopicException}} is a non-retriable exception and is used to indicate
that topic contains invalid chars or topic name is too long etc, and hence not correct to
use. We should, instead, throw the retriable {{UnknownTopicOrPartitionException}} instead.
> We should make sure any callers on this logic should be cleaned up when fixing it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message