kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax" <matth...@confluent.io>
Subject Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB
Date Tue, 29 Jan 2019 02:32:00 GMT
Hi,

during PR reviews, we discovered a couple of opportunities to simply and
improve the KIP and code. Thus, the following minor changes to the
public API are done (the KIP is already updated). I revote is not
necessary as the changes are minor.

 - interface `ValueAndTimestamp` is going to be a class

 - interface `RecordConverter` is renamed to `TimestampedBytesStore` and
we add a static method that converts values from old to new format

 - the three new interfaces `TimestampedXxxStore` don't add any new methods



Let us know if there are any objections. I can also provide more details
why those changes make sense.

Thanks a lot!


-Matthias


On 1/18/19 10:00 PM, Matthias J. Sax wrote:
> +1 from myself.
> 
> 
> I am also closing this vote. The KIP is accepted with
> 
> - 3 binding votes (Damian, Guozhang, Matthias)
> - 3 non-binding votes (Bill, Patrik, John)
> 
> 
> Thanks for the discussion and voting.
> 
> 
> -Matthias
> 
> 
> On 1/16/19 10:35 AM, John Roesler wrote:
>> +1 (nonbinding) from me.
>>
>> Thanks for the KIP, Matthias.
>>
>> -John
>>
>> On Wed, Jan 16, 2019 at 12:01 PM Guozhang Wang <wangguoz@gmail.com> wrote:
>>
>>> Thanks Matthias, I left some minor comments but since they do not involve
>>> in any major architectural changes and I did not feel strong about the
>>> naming etc as well. I'd +1 on the proposal as well.
>>>
>>> Feel free to reply / accept or reject my suggestions on the other DISCUSS
>>> thread.
>>>
>>>
>>> Guozhang
>>>
>>> On Wed, Jan 16, 2019 at 6:38 AM Damian Guy <damian.guy@gmail.com> wrote:
>>>
>>>> +1
>>>>
>>>> On Wed, 16 Jan 2019 at 05:09, Patrik Kleindl <pkleindl@gmail.com> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>> Thanks too
>>>>> Best regards
>>>>> Patrik
>>>>>
>>>>>> Am 16.01.2019 um 03:30 schrieb Bill Bejeck <bbejeck@gmail.com>:
>>>>>>
>>>>>> Thanks for the KIP Matthias.
>>>>>>
>>>>>> +1
>>>>>>
>>>>>> -Bill
>>>>>>
>>>>>> On Tue, Jan 15, 2019 at 7:33 PM Matthias J. Sax <
>>> matthias@confluent.io
>>>>>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I would like to start the vote for KIP-258:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB
>>>>>>>
>>>>>>> The KIP adds new stores that allow to store record timestamps
next
>>> to
>>>>>>> key and value. Additionally, we will allow to upgrade exiting
stores
>>>> to
>>>>>>> the new stores; this will allow us to use the new stores in the
DSL
>>>> with
>>>>>>> a smooth upgrade path.
>>>>>>>
>>>>>>>
>>>>>>> -Matthias
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> -- Guozhang
>>>
>>
> 


Mime
View raw message