From dev-return-99021-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Oct 11 16:02:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2CC218064A for ; Thu, 11 Oct 2018 16:02:40 +0200 (CEST) Received: (qmail 4032 invoked by uid 500); 11 Oct 2018 14:02:39 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 4012 invoked by uid 99); 11 Oct 2018 14:02:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2018 14:02:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 79E4C183E15 for ; Thu, 11 Oct 2018 14:02:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.389 X-Spam-Level: ** X-Spam-Status: No, score=2.389 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, KAM_SHORT=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MnnPZXvrpIel for ; Thu, 11 Oct 2018 14:02:36 +0000 (UTC) Received: from mail-it1-f178.google.com (mail-it1-f178.google.com [209.85.166.178]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CBE2C5F3ED for ; Thu, 11 Oct 2018 14:02:35 +0000 (UTC) Received: by mail-it1-f178.google.com with SMTP id p64-v6so13302643itp.0 for ; Thu, 11 Oct 2018 07:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DBCFDDEdp460Tkf3KAuo0XCm4ZOIK0waaQUrDNgdChY=; b=HxclR2vBYrSurWf61jbbBgTGduJMRto287U84VKwbIc+KILrSqgtMECSmL9JiKDL/i /QiAwlkRr5aHdWR9DyzlFx2PC+D/629KUiTwX2smiH1nC5MZRttY3ZEC1xzMXzbOd6wI 1HFpBd9VfMwC0lgLmGMtGJkpAgzCDRSwNvGliXWFGHICzo7S1hLBxhmWqUl+p9lDgH4H 02qqBhZ0NaTpYgYsM4kJl0f5qgM9Jw9vHytrY/Q0lu/4bSQhNsWKNIeICrL8n8xJcNlP xYaTJxUrkAv0GiAEaNsp/D5xDL2r67ovZnwXsm4e7Tbs0Z1Z2tehE0WR1r8LFl7N3+mn iVdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DBCFDDEdp460Tkf3KAuo0XCm4ZOIK0waaQUrDNgdChY=; b=i29PU61cdOGolUMiX42sm34Flta8AX23ullu2A3j5CmQqGL3It1hPv4h/17WD51Uur VsmZscaOFdL4XivEiQc7T9m+hQGl2a4WRrGBU0sxAaKLEQXqHaAYd9W+W1Hzeg8Si5cD A74kmIS755gXU2RdeJyVCkgHc016FA9R25IxqX9M8wx/2yDVpXhmeae3Bx8g4GmCM1j0 d590kzjFpvNOKj0F2HgN0Sa1dsuzPzSFMWC273ZFuv9JiYLaFn48dKSIREDoZpNlmUG+ NYj0+ifDsKPNVMmf9dSZHJOUJ3fvjwxRjTF+9GbqzxU5DVbg6dShRyQ9gFjCujystx0P Kx9A== X-Gm-Message-State: ABuFfog08HyyJwYiL1ntOtGB77t4xba9IzolztNTo2+2U5HheEMvr0dS iQXWucJc3SmNG9Bizk9JVZm/uvhf6IpwIZ6fFKY= X-Google-Smtp-Source: ACcGV603ykNK9Xkugf/WFcdJZQ2l8ZoJ5cddaWkRn9CK+0MVpN4n3mua3hFM751yfKg3vAnLA5b2W8SyYjFpuaJP7eM= X-Received: by 2002:a24:bd0b:: with SMTP id x11-v6mr113561ite.162.1539266554614; Thu, 11 Oct 2018 07:02:34 -0700 (PDT) MIME-Version: 1.0 References: <513c608c94da4dfa9872f166a57be30c@gsdgeup05etn1.firmwide.corp.gs.com> In-Reply-To: From: Rajini Sivaram Date: Thu, 11 Oct 2018 15:02:23 +0100 Message-ID: Subject: Re: New release branch 2.1.0 To: Edoardo Comar , dev Cc: "Skrzypek, Jonathan" , Dong Lin , Mickael Maison Content-Type: multipart/alternative; boundary="00000000000033d9980577f46c90" --00000000000033d9980577f46c90 Content-Type: text/plain; charset="UTF-8" Copying this discussion on the dev mailing list as well. So the consensus was to use "_" instead of "." in the config values. Can we update both the KIPs to reflect this? As Dong has agreed for these two PRs to go into 2.1.0, I will review and merge them to trunk and 2.1 once the PR builds complete. On Thu, Oct 11, 2018 at 12:49 PM Edoardo Comar wrote: > Thanks Rajini! > > Going to fix / rebase asap. > > Commented on the Config in https://github.com/apache/kafka/pull/4485/files > and waiting for consensus on '.' vs '_' - > > Maybe if you cast your vote, Rajini, you can break the tie , and gain one > friend and one foe :-) > ... > cheers > -------------------------------------------------- > Edoardo Comar > IBM Event Streams > IBM UK Ltd, Hursley Park, SO21 2JN > > > > > From: Rajini Sivaram > To: Dong Lin > Cc: "Skrzypek, Jonathan" , Edoardo Comar > , Mickael Maison > Date: 11/10/2018 12:11 > Subject: Re: New release branch 2.1.0 > ------------------------------ > > > > Hi all, > > I have reviewed both the DNS related PRs. They are both minor KIPs and not > particularly risky. There is a config naming inconsistency which needs to > be sorted out and build conflicts to be resolved (and a few minor comments > to be addressed). If all that is sorted out by tomorrow, then I can do > another review and merge both to 2.1.0 and trunk, ideally by tomorrow. > > Regards, > > Rajini > > > > On Thu, Oct 11, 2018 at 10:22 AM Rajini Sivaram <*rajinisivaram@gmail.com* > > wrote: > Hi Jonathan/Dong, > > I will review both the PRs today to see where we are. > > Thanks, > > Rajini > > On Wed, Oct 10, 2018 at 7:12 PM Dong Lin <*lindong28@gmail.com* > > wrote: > Hey Jonathan, > > If these two PRs can be completed before Oct 15 (the Code Freeze date) and > Rajini thinks these two patches are safe to be committed, then we can > include them in the 2.1.0 release. > > Thanks, > Dong > > On Wed, Oct 10, 2018 at 2:53 AM Skrzypek, Jonathan < > *Jonathan.Skrzypek@gs.com* > wrote: > Hi, > > Could *https://github.com/apache/kafka/pull/4485* > be included in this release ? > I see that *https://github.com/apache/kafka/pull/4987* > is in the list, but the two > KIPs are kind of linked to each other. > > I also see that the client parameters in both jiras don't follow same > convention (KIP-235 goes with "." like most settings in CommonClientConfig, > whereas KIP-302 went for "_" as Rajini pointed out in the PR). > > I think both PRs should be merged or none, to avoid inconsistency issues > in a future release. > > Jonathan Skrzypek > > > -----Original Message----- > From: Dong Lin [mailto:*lindong28@gmail.com* ] > Sent: 05 October 2018 01:22 > To: dev; Users; kafka-clients > Subject: New release branch 2.1.0 > > Hello Kafka developers and users, > > As promised in the release plan > *https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=91554044* > > , > we now have a release branch for 2.1.0 release. Trunk will soon be bumped > to 2.2.0-SNAPSHOT. > > I'll be going over the JIRAs to move every non-blocker from this release > to the next release. > > From this point, most changes should go to trunk. Blockers (existing and > new that we discover while testing the release) will be double-committed. > Please discuss with your reviewer whether your PR should go to trunk or to > trunk+release so they can merge accordingly. > > Please help us test the release! > > Thanks! > Dong > > ________________________________ > > Your Personal Data: We may collect and process information about you that > may be subject to data protection laws. For more information about how we > use and disclose your personal data, how we protect your information, our > legal basis to use your information, your rights and who you can contact, > please refer to: *www.gs.com/privacy-notices* > <*http://www.gs.com/privacy-notices* > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > --00000000000033d9980577f46c90--