kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajini Sivaram (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-7498) common.requests.CreatePartitionsRequest uses clients.admin.NewPartitions
Date Thu, 11 Oct 2018 18:56:01 GMT
Rajini Sivaram created KAFKA-7498:
-------------------------------------

             Summary: common.requests.CreatePartitionsRequest uses clients.admin.NewPartitions
                 Key: KAFKA-7498
                 URL: https://issues.apache.org/jira/browse/KAFKA-7498
             Project: Kafka
          Issue Type: Bug
          Components: clients
            Reporter: Rajini Sivaram
            Assignee: Rajini Sivaram
             Fix For: 2.1.0


`org.apache.kafka.common.requests.CreatePartitionsRequest` currently uses `org.apache.kafka.clients.admin.NewPartitions`.
We shouldn't have references from `common` to `clients`. Since `org.apache.kafka.clients.admin`
is a public package, we cannot use a common class for Admin API and requests. So we should
do something similar to CreateTopicsRequest for which we have `org.apache.kafka.clients.admin.NewTopic`
class used for the admin API and an equivalent `org.apache.kafka.common.requests.CreateTopicsRequest.TopicDetails`
class that doesn't refer to `clients.admin`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message