kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-7386) Streams Scala wrapper should not cache serdes
Date Tue, 11 Sep 2018 23:19:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guozhang Wang resolved KAFKA-7386.
----------------------------------
    Resolution: Fixed

> Streams Scala wrapper should not cache serdes
> ---------------------------------------------
>
>                 Key: KAFKA-7386
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7386
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.0.0
>            Reporter: John Roesler
>            Assignee: John Roesler
>            Priority: Major
>             Fix For: 2.0.1, 2.1.0
>
>
> for example, [https://github.com/apache/kafka/blob/trunk/streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala#L28] invokes
Serdes.String() once and caches the result.
> However, the implementation of the String serde has a non-empty configure method that
is variant in whether it's used as a key or value serde. So we won't get correct execution
if we create one serde and use it for both keys and values.
> The fix is simple: change all the `val` declarations in scala.Serdes to `def`. Thanks
to the referential transparency for parameterless methods in scala, no user-facing code will
break.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message