From dev-return-96790-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Sat Aug 4 10:17:52 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4FFB8180626 for ; Sat, 4 Aug 2018 10:17:52 +0200 (CEST) Received: (qmail 27366 invoked by uid 500); 4 Aug 2018 08:17:51 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 27355 invoked by uid 99); 4 Aug 2018 08:17:51 -0000 Received: from ui-eu-01.ponee.io (HELO localhost) (176.9.59.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Aug 2018 08:17:50 +0000 References: <1533336994.917668.1462918496.68E85BE5@webmail.messagingengine.com> Date: Sat, 04 Aug 2018 08:17:49 -0000 To: From: Chia-Ping Tsai Message-ID: In-Reply-To: <1533336994.917668.1462918496.68E85BE5@webmail.messagingengine.com> x-ponymail-sender: 51ef25fd0a3611d18ffb478ae2ae610bbbd2432c Subject: Re: [DISCUSS] KIP-348 Eliminate null from SourceTask#poll() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Mailer: LuaSocket 3.0-rc1 x-ponymail-agent: PonyMail Composer/0.3 hi Colin Thanks for the reviews! You are totally right. The description of KIP-348 is not accurate. The purpose of KIP-348 is to encourage connector user to substitute empty list to null value, but at the same time returning null still work. I will update the KIP-348 ASAP. cheers, Chia-Ping On 2018/08/03 22:56:34, Colin McCabe wrote: > "No changes to public interface" doesn't seem accurate here. SourceTask#poll is a public interface, right? Kafka connectors that are out-of-tree would certainly break if we disallowed returning null from this method. > > However, reading the KIP more closely, it seems like both null and the empty list will be supported. Perhaps you should discuss this in the compatibility section? Also, the KIP should probably be renamed "deprecate null" rather than "eliminate null" since it will still be possible to return null here, right? > > best, > Colin > > > On Tue, Jul 31, 2018, at 01:10, Chia-Ping Tsai wrote: > > hi all, > > > > Please take a look at the KIP-348[1] if you have free cycel. It bring a > > little change to the usage of SourceTask#poll() > > > > > > [1] > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89065853&moved=true#KIP-348EliminatenullfromSourceTask#poll()- > > Status > > > > Cheers, > > Chia-Ping >