kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam Bellemare <adam.bellem...@gmail.com>
Subject Re: [VOTE] KIP-275 - Indicate "isClosing" in the SinkTaskContext
Date Wed, 29 Aug 2018 12:25:00 GMT
Hi Matt

I posted in the PR about some of the commenting changes. Overall I think
the whole thing looks good, so I would give it a:

+1 non-binding

Adam

On Tue, Aug 28, 2018 at 5:13 PM, Matt Farmer <matt@frmr.me> wrote:

> Given that voting and discussion have stalled out it seems like this is a
> thing that folks aren't particularly interested in. I'll be moving the KIP
> status to abandoned unless I hear an objection in the next day or so. :)
>
> On Thu, May 31, 2018 at 12:39 PM Matt Farmer <matt@frmr.me> wrote:
>
> > Bumping this again as it's been languishing for a few weeks. Would love
> to
> > get further feedback (or know for sure that this won't happen).
> >
> > On Mon, May 14, 2018 at 3:48 PM, Matt Farmer <matt@frmr.me> wrote:
> >
> >> Bumping this thread.
> >>
> >> For anyone who needs a refresher the discussion thread is here:
> >> http://mail-archives.apache.org/mod_mbox/kafka-dev/201803.
> mbox/%3CCAM5dya9x---9M3uEf_wrJL5dw%2B6HLV4%3D5PfKKSTPE1vOHEWC_g%40mail.
> gmail.com%3E
> >>
> >> And there's a work in progress PR open here:
> >> https://github.com/apache/kafka/pull/5002
> >>
> >> Thanks!
> >>
> >> On Wed, Apr 25, 2018 at 1:04 PM, Matt Farmer <matt@frmr.me> wrote:
> >>
> >>> Bump!
> >>>
> >>> We're currently at 1 non-binding +1.
> >>>
> >>> Still soliciting votes here. =)
> >>>
> >>> On Wed, Apr 18, 2018 at 3:41 PM, Ted Yu <yuzhihong@gmail.com> wrote:
> >>>
> >>>> +1
> >>>>
> >>>> On Wed, Apr 18, 2018 at 12:40 PM, Matt Farmer <matt@frmr.me> wrote:
> >>>>
> >>>> > Good afternoon/evening/morning all:
> >>>> >
> >>>> > I'd like to start voting on KIP-275: Indicate "isClosing" in the
> >>>> > SinkTaskContext
> >>>> >
> >>>> https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=75977607
> >>>> >
> >>>> > I'm going to start preparing the patch we've been using internally
> >>>> for PR
> >>>> > and get it up for review later this week.
> >>>> >
> >>>> > Thanks!
> >>>> > Matt
> >>>> >
> >>>>
> >>>
> >>>
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message