kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Manikumar <manikumar.re...@gmail.com>
Subject Re: [DISCUSS] KIP-322: Return new error code for DeleteTopics API when topic deletion disabled.
Date Mon, 02 Jul 2018 14:15:40 GMT
Since this is a minor KIP, If there are no concerns I will start voting
thread.

On Wed, Jun 27, 2018 at 2:24 PM Ted Yu <yuzhihong@gmail.com> wrote:

> bq. set the serialVersionUID = 1L in Kafka exception classes
>
> Indeed. Should have checked earlier.
>
> On Wed, Jun 27, 2018 at 1:38 AM, Manikumar <manikumar.reddy@gmail.com>
> wrote:
>
> >  Hi,
> >
> > Thanks for the review.
> >
> >
> > > nit: you are going to fill in an actual value below in your PR, right ?
> > >     private static final long serialVersionUID = 1L;
> > >
> > >
> >  We normally set the serialVersionUID = 1L in Kafka exception classes.
> >
> > In Motivation, please mention the IllegalStateException scenario.
> > >
> >
> >  IllegalStateException mentioned in the JIRA is specific to user
> > implementaion.
> >  Main issue is we wont get response form the server. In this case, admin
> > client times out the requests.
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message