From dev-return-93983-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu May 10 01:59:23 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 50FAC180649 for ; Thu, 10 May 2018 01:59:22 +0200 (CEST) Received: (qmail 75085 invoked by uid 500); 9 May 2018 23:59:20 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 75063 invoked by uid 99); 9 May 2018 23:59:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2018 23:59:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B17221807C4 for ; Wed, 9 May 2018 23:59:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent-io.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ncF-Tw1cMlvx for ; Wed, 9 May 2018 23:59:18 +0000 (UTC) Received: from mail-pl0-f48.google.com (mail-pl0-f48.google.com [209.85.160.48]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 01C1E5F1E7 for ; Wed, 9 May 2018 23:59:17 +0000 (UTC) Received: by mail-pl0-f48.google.com with SMTP id t12-v6so187718plo.7 for ; Wed, 09 May 2018 16:59:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent-io.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to; bh=qQImxfeOVBA+BeckLoZSwijvYPcrTmjshPD5pJ8YSnc=; b=AFceTNCUcDAm2jWC4jsWDP3CWH+cnhqSPmLbZhnWYTdZkRZjOxkHR2Da6TWJxPwWxH NulqWIdcWGXdBCS+q8HpOjHacJDaSwkzeFh7lm1IVAkQ6wgGZ1kQynimMOKrLfJlenHD BcfT+MDZBP9yqDHcjXdOKE6K5NwDiBLdNN1aet4MQJ1SQ6JDw79RRH0AWCvVXKCTkzIF fUWL/I4CIvDZ/I0Pny4NC7e3GToouDd+9cnj2+vfgbZtQEM5ShwW9gf+ALcTXnSnQbr+ Uw63xVcn18cH+ymzmzGQ8d+pMGp0Luuvk4GgkiIcEd1QoteDbI5f6S9RFfJx0Ms+OtPa qRyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to; bh=qQImxfeOVBA+BeckLoZSwijvYPcrTmjshPD5pJ8YSnc=; b=j20Aw5YXsWNvvoTmNxGecGCsIP/u+6vAnu+cgHw97Wj8wnNzqgLAGG4yPtHIX3Co31 9fIiO/EpperS3ax2kDrEf0IjkU1VtudrT0+fPYvbk5rwvirD9Ug+sHHS+J2hr5N+ghTy ZcfrZhhfsqiva0Y2kPTwF8pBmTrNOEG8f/TZh8BO2e/QAOdz/Wp6MNdZBlIAcKKcLuh8 GE3mfWvRCr8R2aoeFyn0uz55097QgL+oBcZXtBMTN4kW2+gF/Kiz+NsoX+7xJfuQZMPW P141lpL3znLh3TqQs0BGMnuwNuyFgO4cc6nypQszUhYVZyyNzYvHv4IQwPKeu54Gtkl7 z5Uw== X-Gm-Message-State: ALQs6tAHYO25UBgTXD98gzw7ryN0hSQ/XB5i25DfAao+2dzzIQHCXH8m tKyUuEnEedEeM5PReNnYNJ8oe+F1/Rs= X-Google-Smtp-Source: AB8JxZoNWZw8Cj0ON4TZVLGljP7Pn0t5IiR2jI7kcRtwsK/jWxJ7/vvelXTp8v6FecbA0fCgDpJEkA== X-Received: by 2002:a17:902:8b85:: with SMTP id ay5-v6mr15085638plb.30.1525910356703; Wed, 09 May 2018 16:59:16 -0700 (PDT) Received: from Matthias-Sax-Macbook-Pro.local (50-0-2-20.static.sonic.net. [50.0.2.20]) by smtp.gmail.com with ESMTPSA id u4-v6sm5801578pgn.10.2018.05.09.16.59.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 16:59:15 -0700 (PDT) Subject: Re: Use of a formatter like Scalafmt To: dev@kafka.apache.org References: <5af38112.0122620a.163bf.fc8e@mx.google.com> From: "Matthias J. Sax" Openpgp: preference=signencrypt Autocrypt: addr=matthias@confluent.io; prefer-encrypt=mutual; keydata= xsFNBFcGWisBEAD4+gj1tJcLJRckkbZjdJpd1347/Zwndn8R6r2X+YYS5EgwzP5OQHl3Q6jl hAISoqBEfDeTJffsxd1wWL+6wKU4Y7zCkH/3aL/7znOlfaewpgJP3x/naawgvnJ0jlPlJtev MlAbG+9P6aEVxYfML59KBtRKzd6OZbSh0VzCJVCvkslv+LZqR94lhA0rArupqe7EO9DuP4/V bvnDxx1dZFtEK4n4wJYsRkF+TuxGClLcfosfM0oHTZeolus+rJTi7wxrbcTOlTmOMW0Wf9rK AobXsSz838RJenQqe3X0s5EBKCoIdI2SCQiTfcJ2JTVt6Ip1IDuEVqMQmtz7i2l3Rlml0GDa gODehmeMczVIBeO0+cppzOEynjQlWLCbJ8XEjISMI87Ied6DGbEYKLnG4ucRjM//8syKI4T+ Z90Y060jhWxrvr2pGqPPaU3qvIXW1D1mchXE1ba4HOdKb6fA7j5NU47WA2YmWRDhfM4exE0Q mD3Jfjfjyuch2rGhT3twSWHk7v5zlINwOfTIfeXvShqxNzJRFf6MudFnFbgmMTo51LmPcXHz 3tUaRNoky/HRpSxU7h145SgltrKSmYgWUnG4Y3qySyiPVKfBUBi/e5dYTk4Y0NDWGhZxOXCs ZV0NQsuoqFD82LrglwECrcdHd2QaKnIX2eKB7j63dMsexFDjewARAQABzSdNYXR0aGlhcyBK LiBTYXggPG1hdHRoaWFzQGNvbmZsdWVudC5pbz7CwXgEEwECACIFAlcGWisCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAAAoJEDwRZiHEirRPWcoP/if/UkALwOvkct/IufpQhJ9qmg/a +QrSkDbPFrkWA7r9aMnaX8C5xuFgFuekT2aMzYYEr3eQwNHeeeEEFUhJQnMsKrjMw55w8+J5 Zhzdg8OKepFT0BOovXzITZcyqBW5JdMjfwEkdztBmPHbvWCCjglSllCvNDorxF1FCYuiL+F3 aBx0SaKaXuNhA4GO2IBY68SQ04ueeSbKbnukyWdAYXObBPBvbcoJXeesX6QvANxSjCqPHRsc czAr1mADzPN58nRXrOYgeonhPROYRlhLyEJM9CnGby/GRb9WfrKFwQVVjpNT0dD9vOvobmEp o4//m6qeXh6xC/egW9vBl63fJNOb/A6T1JdFdU8VWpUofAZtPHE61Y11AmkL7EoY5eUhlL0i jCQ4+K4wERP5NGOBEHe6wfxWoQMnPwnj59N8GylCOMhaVaIYqqRuAssMWyliX8nAj0dO3Hbw EZmBMt/xAAZpXCJU3iDS1G0+fs5LIIBWJodBvjec3DpIlib3PGG6IKPfkwpTfyoStRaPAc+X 085/KhgI8hM1nCxzI/0iQSsuyrJikYcCiB+EukaxTy1TS7O3Ul7Sg6f5f2YXB3jh9rPgZf/C y8iIJDyY+zfJLaYPO3uMEtqW69SWVeLM2viy5pj3MtEzDgC16OLINRdIsibPXRchdv7KN2FZ w4uvgTnZzsFNBFrC7GQBEADRIp0Uj4DUrFn049ki3qTuxanbr+76JUeNZ/WT0EUnBq4+v/fB KCHNQxLJJN3HdQLupcauDYIRAnJg5gB9wOcKgjMXmwZ3F8pX/j8Hmf7CEZPbElh64ZpxkNFc 83k6ZiJ2hsQk6F7K3LvqsvgkKAcfHY/Fd/Xwo4YodrcX0OWr+Szp++FPDIHWpiGNo16uobt8 2xUWN5KW0YPiG2gmvHeGGGVeXScn5I76MpJlt1lRCt/uWrYHYc8rupywIn/wCBwKKoNdXaYL TdVlwUB6wxGjNQphBXej173Pckwx+xwb+1KngWS/I/YXGan7+aBJTfkM2kxACqexsxS8NgUx K1VuELlsZRa2AxpzeSmR6Ev6YAAIwjdgiiuTKc3D9LzSb1zQZJ/xrpRy2OdJEXELCFjil0eM ANQH4jovicaWrSd0EH4Ipk6TXjHpkNnGQ2Oy7kzMcwEvaQxQ4SszOSdqDjwR3vQ5dV7d5RCP 1+9qYzFb/sKpoQi9FK/fVUIcPnIdv12B4uU97Vs+ONrOFl8ER+d36fcpogpyNRWSZIttQ96P +kKOAA2L+BP3UdLpchQu8/t+0BZyVmgySWSo8oJA2qFB6rMa8ZsFQoK8m/z7ukBzx7E9geKK 2ZOpqRawJ8nCiDb1nBmJYwgl6ltWV3utg9nLr5oY+35mhnzUszBSoiZlCQARAQABwsF8BBgB CAAmFiEEV9+AVI/wFUXaxShcPBFmIcSKtE8FAlrC7GQCGwwFCQHhM4AACgkQPBFmIcSKtE9O hA/+N5Da5bZVMyEWXuSoASgEAC8uWzT8cVy78XDoGzlPXfEmtz0YC+sWR4psWWIbDpJOcpKe D2AcNuYl24ida2HE+h09LZq8l9EzWpvI30fR9c5LSrKCQJFHyfla3JRCZPr8yT4oQeMYls/2 hP8tk+R2IeZ2aRxLLXCdyBYbmlhK+3y38XZuvzyxbwIQ0plWB26FgnmQZ1PVcU2lfgs3IYBg Vog8gIfvdqxPdxBnV05yE5WhqcdplTmNXyaV4eU1kNfpIMvuhPo1hVKEAznk6csKQcjYBte5 kBLtJKgYR3/lMU2OhF7nBya2HqSWnwCYk7L7f26t0WIVa8JztLkGcEktHFZHs9i0tqGeUSe5 ydiB2tF07K4g1XftQB4VbDSoogp8InTlf2Bfmad0MRcOnWR8BSKyYxgpMljD5wbFnN975s+F d+avW1umqE0raN/chgWQbZf5365hjcWgDzP+o3Vg1aD37CkrWJ+pMFS/FB9VTBYLAdXQvu7O oT7wtga9MXxH3S/c/C5LtFgVYSwuZhGhmB2cKbTMhwToG6rxREjvcYIOA1afynTpMjlTfIIk QPzqnpk6ZIIpcxq+T+PGoiAwV3XmlpPlJeumA1tBSj4OBqVvHYDObcnQaibBK6fxihTgLQHW 8SyMqdjjZyUaNzN3jxG7826WEzmGIs1Js4gPbSM= Organization: Confluent Inc Message-ID: <2b534c63-8836-0813-6281-2370d4344f2e@confluent.io> Date: Wed, 9 May 2018 16:59:14 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FkbIFlt4tCojgROfAxVWboUN6AU3n0ktv" --FkbIFlt4tCojgROfAxVWboUN6AU3n0ktv Content-Type: multipart/mixed; boundary="EYxaK8PHbEzHseW7dFhF3MozT3gV5uDrE"; protected-headers="v1" From: "Matthias J. Sax" To: dev@kafka.apache.org Message-ID: <2b534c63-8836-0813-6281-2370d4344f2e@confluent.io> Subject: Re: Use of a formatter like Scalafmt References: <5af38112.0122620a.163bf.fc8e@mx.google.com> In-Reply-To: --EYxaK8PHbEzHseW7dFhF3MozT3gV5uDrE Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Joan, thanks for starting this initiative. I am overall +1 However, I am worried about applying it to `core` module as the change is massive. For the Kafka Streams Scala module, that is new and was not released yet, I am +1. A personal thing about the style: the 2-space indention for JavaDocs is a little weird. /** * */ is changed to /** * */ Not sure if this can be fixed easily in the style file? If not, I am also fine with the change. This change also affect the license headers of many files and exposing that those use the wrong comment format anyway. They should use regular comments /* * */ but not JavaDoc comments /** * */ (We fixed this for Java source code in the past already -- maybe it's time to fix it for Scala code base, too. -Matthias On 5/9/18 4:45 PM, Joan Goyeau wrote: > Hi Ted, >=20 > As far as I understand this is an issue for PRs and back porting the > changes to other branches. >=20 > Applying the tool to the other branches should also resolve the conflic= ts > as the formattings will match, leaving only the actual changes in the d= iffs. > That's what we did sometime ago at my work and it went quiet smoothly. >=20 > If we don't want to do a big bang commit then I'm thinking we might wan= t to > make it gradually by applying it module by module? > This is one idea do you have any other? >=20 > I know formatting sounds like the useless thing that doesn't matter and= I > totally agree with this, that's why I don't want to care about it while= > coding. >=20 > Thanks >=20 > On Thu, 10 May 2018 at 00:15 Ted Yu wrote: >=20 >> Applying the tool across code base would result in massive changes. >> How would this be handled ? >> -------- Original message --------From: Joan Goyeau >> Date: 5/9/18 3:31 PM (GMT-08:00) To: dev@kafka.apache.org Subject: U= se >> of a formatter like Scalafmt >> Hi, >> >> Contributing to Kafka Streams' Scala API, I've been kinda lost on how >> should I format my code. >> I know formatting is the start of religion wars but personally I have = no >> preference at all. I just want consistency across the codebase, no >> unnecessary formatting diffs in PRs and offload the formatting to a to= ol >> that will do it for me and concentrate on what matters (not formatting= ). >> >> So I opened the following PR where I put arbitrary rules in .scalafmt.= conf >> < >> https://github.com/apache/kafka/pull/4965/files#diff-8af3e1355c23c331e= e2b848e12c5219f >>> >> : >> https://github.com/apache/kafka/pull/4965 >> >> Please let me know what do you think and if we can move this forward a= nd >> settle something. >> >> Thanks >> >=20 --EYxaK8PHbEzHseW7dFhF3MozT3gV5uDrE-- --FkbIFlt4tCojgROfAxVWboUN6AU3n0ktv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIzBAEBCgAdFiEESn/iOv2tmCkcP0KLVp2sL37kObwFAlrzi1MACgkQVp2sL37k ObzELQ/+K/TDbHB8TSzNoY2mtMITpb6RRBePVF9Wsm8xaE3Hvh4J5WPzR/rwGyCK GvHvlSKIVQobQXI7qi1YcMvi8D4k2EzHyOhP9kWHrXZ+G4jJUM3U1VsiSOq4dZ9s 0PEBVkfFrewwIayvhuyz/wZshmcSQJMPAWx1CrXQPvHXX5gPI4dyAwYmNZ/fUufY nW01M2DEFmVGTaf+IRBhiKuuIXRTdbzIyttWGKDePeGsIIu8e/DFIobX2WPvXWXN f0CLLtUs4CNdV5+04Wuxqfd+qIp8tCCLqb6rdV0JjrBxG62ghghb3Yic/pZjw9A6 PouK1SZt28XtAB23DBWT1NJ5Fw3oO08e5lw0+24i66AcWE10TBLWxMdjB+ELgdRz gIx7Yqmt9GHuShtzb5EBADEtm/nCI4fKMtv913WqRgos+FgGzA23r4mN9cwkFgiq bin/p9ukyFNZ8OHUPjWEfanwHLoiCzmFUM5midk2NaY4uEKJsqJAl2NuSuHoOKm8 5PrrJvShYWW4c/sasctDn0zlr+D0oJ4TPJ0GNyTa+NHEJ5D6Ppj0KDBUdZZaLuZa VobPyLcOFKxpQBMsEUy2ZJWQMPV5bfBCiaQMRhZRz8rXtUX9vSHXiPMh4N2mNA9E xVkjoaZ2EzMoF9lWX53f30+ee78eF87zkBmTa7T8TIpKoYS2hAo= =znZd -----END PGP SIGNATURE----- --FkbIFlt4tCojgROfAxVWboUN6AU3n0ktv--