kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax" <matth...@confluent.io>
Subject Re: StoreFactory deprecated? Any JIRA issue to work on?
Date Tue, 13 Feb 2018 21:25:27 GMT

thanks for reporting this. I agree that `StoreFactory` should be
deprecated -- I guess it slipped in KIP-182.

Because it's still a public class, this would require a KIP (should be
straight forward to do, though).

For `AbstractStream.storeFactory`, we don't need to deprecate it because
it's an internal class, we can remove it directly if not needed anymore.
Of course, we still maintain the old API atm so we still need to keep it
for now.

Feel free to file a JIRA and/or do a KIP for deprecating `StoreFactory`.



On 2/13/18 8:27 AM, Jacek Laskowski wrote:
> Hi,
> While reviewing the code I've noticed that StoreFactory is used exclusively
> from Stores.create [1] which is deprecated. That gave me impression that
> StoreFactory should be deprecated/removed too. What
> about AbstractStream.storeFactory [2] and its uses then?
> Is there a JIRA issue to work on it? I'd like to give it a try (been a
> while since I've done Java, but may pretend it's Scala and try :))
> [1]
> https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/state/Stores.java?utf8=%E2%9C%93#L257
> [2]
> https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java?utf8=%E2%9C%93#L112
> Pozdrawiam,
> Jacek Laskowski
> ----
> https://about.me/JacekLaskowski
> Mastering Spark SQL https://bit.ly/mastering-spark-sql
> Spark Structured Streaming https://bit.ly/spark-structured-streaming
> Mastering Kafka Streams https://bit.ly/mastering-kafka-streams
> Follow me at https://twitter.com/jaceklaskowski

View raw message