From dev-return-91142-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Jan 23 21:03:16 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 05A3D180621 for ; Tue, 23 Jan 2018 21:03:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E9969160C3A; Tue, 23 Jan 2018 20:03:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3A2D6160C24 for ; Tue, 23 Jan 2018 21:03:15 +0100 (CET) Received: (qmail 53943 invoked by uid 500); 23 Jan 2018 20:03:13 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 53931 invoked by uid 99); 23 Jan 2018 20:03:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jan 2018 20:03:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C0B331A0A16 for ; Tue, 23 Jan 2018 20:03:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.979 X-Spam-Level: * X-Spam-Status: No, score=1.979 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent-io.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MBlZYWQ00coI for ; Tue, 23 Jan 2018 20:03:10 +0000 (UTC) Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 677555F640 for ; Tue, 23 Jan 2018 20:03:10 +0000 (UTC) Received: by mail-oi0-f49.google.com with SMTP id m65so1231345oig.5 for ; Tue, 23 Jan 2018 12:03:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=+T2PjZSyUC8wLfl4E7qhSfEJG7WMyWZApW/jKCwGR04=; b=scQmb0o1MzFOlpJMETvbVb76ZdQY82zaL1RU3A89knQpUanbcVqQiYTWy451j3V0Sa zkGIIiw9DABoJc/qgUoEWexg3B+F6I9mvMvu8+k3MMOQu03z7Us8Tad02EBOu2Vpj7xk X+RUyWEUgdrqMxR+mbECIGHsWNr/gzaiJr5l760fKNnfyEiV6O63KOrs1SFb6vG1HiUT J/9JMgInAbe4P0iewHzNQ2hrBlDcWCaSWlla6HKrrmy71FlheCyniFeeOmt5+jIfclBt ue4h3ZnMcIU3h9wIIdfJ1lSoKwsrjWXFEqjNF7erhr7pgSGwsF2MIXJ7yZUimHaCssCl fuSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=+T2PjZSyUC8wLfl4E7qhSfEJG7WMyWZApW/jKCwGR04=; b=qxQ+g/l7GN+eIoYm+NwHYG1LM4FF7nGMKFUJp0Rqh/CIl2JQBHlk6USoHtvyaGBbUa Wn+wlHqquP6L2yQw1XahljsbQl2kzi1OXXydP//PtepPbvqCwOz43axDqtmlmCggBMKl MyjTRtoUMfIZXdt0aJg5rlTUOYLrTBeOMr7HM/HGHRD++ClG2+9k7wd0c9t9hy8ZIeR9 r82C9ZWourRZdxJ9EDLmgMne18DHu6MZ3bjB1uEHuiaz8ObBKZoYZ3Czf/ToxNkfJOtC Zxd+xI5r5uKSR+lbtePQ5FTtF7zF8V5ZFPiGWOP5+IUwXZbd3gfIZJsUxzRqwR6G397r gGBg== X-Gm-Message-State: AKwxytd84SK9xJb6yFY/BhoPxSud9Ng86899ulGMUU2kZ+y1v2PkUFM6 qzpR+DRqf404liME0gqo0/BZvm6KwF9CJKBYYIYHvQ== X-Google-Smtp-Source: AH8x225F1y3RiSAzu8mQg1BfefBJDK+wHfloWocw/MI6EPZ0u5FmSxRFKFOuBXEFNjFjdNvF/o87CcbBgsZDjRG8Q+k= X-Received: by 10.202.60.134 with SMTP id j128mr7730029oia.268.1516737789373; Tue, 23 Jan 2018 12:03:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.146.198 with HTTP; Tue, 23 Jan 2018 12:03:08 -0800 (PST) In-Reply-To: References: From: Jason Gustafson Date: Tue, 23 Jan 2018 12:03:08 -0800 Message-ID: Subject: Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="001a113cd1aa27479805637709b0" --001a113cd1aa27479805637709b0 Content-Type: text/plain; charset="UTF-8" Hey Randall, It seemed a bit cleaner to me, but I'm not sure if whether there is any advantage to keeping the interfaces decoupled. I'd probably suggest going for the simpler API unless you can think of a good reason not to. -Jason On Tue, Jan 23, 2018 at 8:47 AM, Randall Hauch wrote: > I mostly just followed the pattern of the Converter methods, which also > take the individual components. Really, the only advantage of the current > approach is that the HeaderConverter implementations are a bit more > decoupled as they are not aware of the Header/Headers API nor the > implementation classes, and they don't instantiate the Header instance. > Instead, the runtime is entirely responsible for that. > > However, using the Header interface directly in the method parameters is > certainly a bit cleaner from an API perspective. I'm open to this > suggestion if you or anyone else prefers it. It'd be a minor change at this > point. > > Randall > > On Mon, Jan 22, 2018 at 7:30 PM, Jason Gustafson > wrote: > > > +1 (binding) > > > > Just one minor comment. It seems a little surprising that HeaderConverter > > does not use the Header interface. I expected something like this: > > > > Header toConnectHeader(String topic, String headerKey, byte[] value); > > byte[] fromConnectHeader(String topic, Header header); > > > > Was there a reason not to do it this way? > > > > Thanks, > > Jason > > > > On Mon, Jan 22, 2018 at 4:45 PM, Ted Yu wrote: > > > > > +1 > > > > > > On Mon, Jan 22, 2018 at 2:48 PM, Gwen Shapira > wrote: > > > > > > > +1 (binding) > > > > > > > > This is going to be HUGE! Thank you Randall. > > > > > > > > On Mon, Jan 22, 2018 at 1:18 PM Konstantine Karantasis < > > > > konstantine@confluent.io> wrote: > > > > > > > > > Great addition! > > > > > > > > > > +1 (non-binding) > > > > > > > > > > Konstantine > > > > > > > > > > On Sun, Jan 21, 2018 at 7:26 PM, Ewen Cheslack-Postava < > > > > ewen@confluent.io> > > > > > wrote: > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > Thanks for the work on this -- not a small upgrade to the Connect > > > APIs! > > > > > > > > > > > > -Ewen > > > > > > > > > > > > On Fri, Jan 19, 2018 at 3:37 PM, Randall Hauch > > > > > wrote: > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > I'd like to start the voting on this KIP to add support for > > headers > > > > in > > > > > > > Connect.: > > > > > > > > > > > > > > *https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > > 145+-+Expose+Record+Headers+in+Kafka+Connect > > > > > > > > > > > > > 145+-+Expose+Record+Headers+in+Kafka+Connect>* > > > > > > > > > > > > > > This does add a fair number of interfaces to our public API, > and > > > > > defines > > > > > > > some behavioral changes as well. > > > > > > > > > > > > > > Thanks! Your feedback is highly appreciated. > > > > > > > > > > > > > > Randall > > > > > > > > > > > > > > > > > > > > > > > > > > > > --001a113cd1aa27479805637709b0--