kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From huxihx <...@git.apache.org>
Subject [GitHub] kafka pull request #4326: KAFKA-6362: maybeAutoCommitOffsetsAsync should try...
Date Fri, 15 Dec 2017 02:43:22 GMT
GitHub user huxihx opened a pull request:

    https://github.com/apache/kafka/pull/4326

    KAFKA-6362: maybeAutoCommitOffsetsAsync should try to discover coordinator

    Currently, `maybeAutoCommitOffsetsAsync` may not retry to find out coordinator even after
the coordinator goes back to service. As a result, all asynchronous offset commits will fail.
    
    This patch refines `maybeAutoCommitOffsetsAsync` to have it periodically retry the coordinator
discovering.
    
    *More detailed description of your change,
    if necessary. The PR title and PR message become
    the squashed commit message, so use a separate
    comment to ping reviewers.*
    
    *Summary of testing strategy (including rationale)
    for the feature or bug fix. Unit and/or integration
    tests are expected for any behaviour change and
    system tests should be considered for larger changes.*
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huxihx/kafka KAFKA-6362

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4326
    
----
commit a2e2da2b2215da2053ffc9e6dace4a36e8777e12
Author: huxihx <huxi_2b@hotmail.com>
Date:   2017-12-15T02:39:31Z

    KAFKA-6362: ConsumerCoordinator.maybeAutoCommitOffsetsAsync should try to discover coordinator.
    
    Currently, `maybeAutoCommitOffsetsAsync` may not retry to find out coordinator even after
the coordinator goes back to service. As a result, all asynchronous offset commits will fail.
    
    This patch refines `maybeAutoCommitOffsetsAsync` to have it periodically retry the coordinator
discovering.

----


---

Mime
View raw message