Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: =?utf-8?Q?Re=3A_=5BDISCUSS=5D_KIP-225_-_Use_tags_for_consumer_?=
 =?utf-8?Q?=E2=80=9Crecords=2Elag=E2=80=9D_metrics?=
From: James Cheng <wushujames@gmail.com>
In-Reply-To: <CAMi2YZRiDKHvZ4A_MtZKSpQMGFmkG08my+fxgyK9NS6gWsJBaA@mail.gmail.com>
Date: Thu, 16 Nov 2017 00:13:00 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <DEFF8AC9-F482-4BCD-BB76-76DE3DA51702@gmail.com>
References: <CAMi2YZRaDk+Rx6UO6F=UvJKV3nsmNybg-cmjy3=SNseUS8=E1g@mail.gmail.com>
 <CAMi2YZRiDKHvZ4A_MtZKSpQMGFmkG08my+fxgyK9NS6gWsJBaA@mail.gmail.com>
To: dev@kafka.apache.org
archived-at: Thu, 16 Nov 2017 08:13:14 -0000

This KIP will break backwards compatibility for anyone who is using the =
existing attribute names.

Kafka devs, I believe that metrics are a supported interface, and so =
this would be a breaking change. In order to do this, we would need a =
deprecation timeframe for the old metric, and a transition plan to the =
new name. Is that right? I'm not sure how we deprecate metrics...

During the deprecation timeframe, we could duplicate the metric to the =
new name.

-James

On Nov 13, 2017, at 6:09 AM, charly molter <charly.molter@gmail.com> =
wrote:
>=20
> Hi,
>=20
> There doesn't seem to be much opposition to this KIP, I'll leave a =
couple
> more days before starting the vote.
>=20
> Thanks!
>=20
> On Thu, Nov 9, 2017 at 1:59 PM, charly molter =
<charly.molter@gmail.com>
> wrote:
>=20
>> Hi,
>>=20
>> I'd like to start the discussion on KIP-225.
>>=20
>> This KIP tries to correct the way the consumer lag metrics are =
reported to
>> use built in tags from MetricName.
>>=20
>> Here's the link:
>> =
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=3D7468664=
9
>>=20
>> Thanks!
>> --
>> Charly Molter
>>=20
>=20
>=20
>=20
> --=20
> Charly Molter