kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cnZach <...@git.apache.org>
Subject [GitHub] kafka pull request #4115: KAFKA-6105: load client properties in proper order...
Date Mon, 23 Oct 2017 07:18:24 GMT
GitHub user cnZach opened a pull request:

    https://github.com/apache/kafka/pull/4115

    KAFKA-6105: load client properties in proper order for kafka.tools.EndToEndLatency

    Currently, the property file is loaded first, and later a auto generated group.id is used:
    consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" + System.currentTimeMillis())
    so even user gives the group.id in a property file, it is not picked up.
    
    we need to load client properties in proper order, so that we allow user to specify group.id
and other properties, excludes only the properties provided in the argument list.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnZach/kafka cnZach_KAFKA-6105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4115
    
----
commit d83f84e14c556fffddde2a74469e5be43fc99b10
Author: Yuexin Zhang <zach.yx.zhang@gmail.com>
Date:   2017-10-23T07:13:10Z

    load client properties in proper order, so that we allow user to sepcify group.id and
other propeties, excludes only the properties provided in the argument list

----


---

Mime
View raw message