kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Viktor Somogyi <viktorsomo...@gmail.com>
Subject Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new AdminClient
Date Thu, 07 Sep 2017 19:29:51 GMT
Hi Paolo,

To me it makes sense, let's do it :).

Viktor

On Thu, Sep 7, 2017 at 4:37 PM, Paolo Patierno <ppatierno@live.com> wrote:

> So as commented on the KAFKA-5723 JIRA my plan could be :
>
>
>   *   Using the KAFKA-3268 as umbrella for the others JIRAs related to
> tools refactoring
>   *   Regarding common components needed by developers involved on
> different tools, I will create a subtask in this JIRA (i.e. related to the
> new CommandOptions class)
>   *   For such subtask I'll open a PR with the work I have already done so
> a simple PR
>   *   The committers and the other "tools" developers will review the PR
> for making changes
>   *   When the PR will be merged the developers can continue on the
> different JIRAs related to different tools making their PRs
>
>
> Does this plan make sense ?
>
>
> Paolo Patierno
> Senior Software Engineer (IoT) @ Red Hat
> Microsoft MVP on Windows Embedded & IoT
> Microsoft Azure Advisor
>
> Twitter : @ppatierno<http://twitter.com/ppatierno>
> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> Blog : DevExperience<http://paolopatierno.wordpress.com/>
>
>
> ________________________________
> From: ismaelj@gmail.com <ismaelj@gmail.com> on behalf of Ismael Juma <
> ismael@juma.me.uk>
> Sent: Thursday, September 7, 2017 10:56 AM
> To: dev@kafka.apache.org
> Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new
> AdminClient
>
> No, I'm suggesting that we think how can merge smaller PRs to trunk. Having
> a separate branch doesn't help as it can diverge from trunk and a committer
> would be needed to merge rebases, etc.
>
> Ismael
>
> On Thu, Sep 7, 2017 at 11:25 AM, Paolo Patierno <ppatierno@live.com>
> wrote:
>
> > Hi Ismael,
> >
> > first of all thanks for your reply.
> >
> > So as far as I understood having a branch in the Kafka repo could be
> > better for you as committer to validate small PRs from us and not a big
> one
> > at the end, right ?
> >
> >
> > Paolo Patierno
> > Senior Software Engineer (IoT) @ Red Hat
> > Microsoft MVP on Windows Embedded & IoT
> > Microsoft Azure Advisor
> >
> > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> >
> >
> > ________________________________
> > From: ismaelj@gmail.com <ismaelj@gmail.com> on behalf of Ismael Juma <
> > ismael@juma.me.uk>
> > Sent: Thursday, September 7, 2017 10:19 AM
> > To: dev@kafka.apache.org
> > Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new
> > AdminClient
> >
> > I would also add that it would be easier to review if there were smaller
> > PRs than one big PR. So, it may be worth thinking how progress could be
> > made more incrementally.
> >
> > Ismael
> >
> > On Thu, Sep 7, 2017 at 11:17 AM, Tom Bentley <t.j.bentley@gmail.com>
> > wrote:
> >
> > > I can't speak for the committers, but there's nothing to stop you
> > > submitting PRs against each others branches. It just needs you to agree
> > > which of you will host the integration branch. This would be pretty
> much
> > > exactly the same developer experience as of the branch was in the main
> > > Kafak repo AFAICS, except the committers wouldn't have to be involved
> > with
> > > merging your PRs into your integration branch (which is probably a
> > benefit
> > > to both you and them).
> > >
> > > On 7 September 2017 at 10:57, Paolo Patierno <ppatierno@live.com>
> wrote:
> > >
> > > > Hi committers,
> > > >
> > > >
> > > > as already asked by Viktor on the JIRA yesterday can you give us a
> > > > feedback/advice on how to move on that ? Thanks !
> > > >
> > > >
> > > > Paolo Patierno
> > > > Senior Software Engineer (IoT) @ Red Hat
> > > > Microsoft MVP on Windows Embedded & IoT
> > > > Microsoft Azure Advisor
> > > >
> > > > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > > > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> > > > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> > > >
> > > >
> > > > ________________________________
> > > > From: Paolo Patierno <ppatierno@live.com>
> > > > Sent: Thursday, August 17, 2017 3:18 PM
> > > > To: dev@kafka.apache.org
> > > > Subject: Re: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the
> > new
> > > > AdminClient
> > > >
> > > > As I started on working to develop the TopicCommand tool in Java
> (with
> > > > this PR<https://github.com/apache/kafka/pull/3514>), Andrey is
> working
> > > on
> > > > another one and he started to use some of my classes (mostly related
> to
> > > > handling command line arguments) just with copy/paste/modify so
> > > duplicating
> > > > the code.
> > > >
> > > > As mentioned in the JIRA discussion<https://issues.
> > > > apache.org/jira/browse/KAFKA-5723>, having a branch in the original
> > repo
> > > > could help us to have personal forks with such branch, opening PRs
> > > against
> > > > this branch and having the common code there (syncing the code with
> > > forked
> > > > repos).
> > > >
> > > > In conclusion the problem is : having more people working on
> different
> > > > pieces of code which have some common code (still under development)
> > not
> > > > yet available in the original repo.
> > > >
> > > > At least it's the idea we had but maybe the committers have a
> different
> > > > way to go in such situations. Any feedback is really appreciated :-)
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Paolo
> > > >
> > > >
> > > > Paolo Patierno
> > > > Senior Software Engineer (IoT) @ Red Hat
> > > > Microsoft MVP on Windows Embedded & IoT
> > > > Microsoft Azure Advisor
> > > >
> > > > Twitter : @ppatierno<http://twitter.com/ppatierno>
> > > > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno>
> > > > Blog : DevExperience<http://paolopatierno.wordpress.com/>
> > > >
> > > >
> > > > ________________________________
> > > > From: Andrey Dyachkov <andrey.dyachkov@gmail.com>
> > > > Sent: Thursday, August 17, 2017 3:10 PM
> > > > To: dev@kafka.apache.org
> > > > Subject: KAFKA-5723: Refactor BrokerApiVersionsCommand to use the new
> > > > AdminClient
> > > >
> > > > Good day,
> > > > I am quite new here, my apologies for being kind of pushy.
> > > > We had discussion here https://issues.apache.org/
> > jira/browse/KAFKA-5723,
> > > > that having separate branch for implementing the whole change
> > > > https://issues.apache.org/jira/browse/KAFKA-3268 would simplify dev
> > > > process. Could some of committers give a hand here?
> > > >
> > > > Also could you review pr https://github.com/apache/kafka/pull/3671
> and
> > > add
> > > > me to contributors list in order to add myself to ticket assignee?
> > > >
> > > > Thank you!
> > > > --
> > > >
> > > > With great enthusiasm,
> > > > Andrey
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message