Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F5E0200CDD for ; Mon, 7 Aug 2017 17:22:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8DD1E164D41; Mon, 7 Aug 2017 15:22:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D265F164D35 for ; Mon, 7 Aug 2017 17:22:01 +0200 (CEST) Received: (qmail 13610 invoked by uid 500); 7 Aug 2017 15:22:00 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 13588 invoked by uid 99); 7 Aug 2017 15:22:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Aug 2017 15:22:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E9A76180235 for ; Mon, 7 Aug 2017 15:21:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.401 X-Spam-Level: X-Spam-Status: No, score=-0.401 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.8, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KKuLVzKrqKlE for ; Mon, 7 Aug 2017 15:21:55 +0000 (UTC) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0AC2D5FAC5 for ; Mon, 7 Aug 2017 15:21:55 +0000 (UTC) Received: by mail-io0-f182.google.com with SMTP id g35so3748405ioi.3 for ; Mon, 07 Aug 2017 08:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=AnpvcgBNouDltbARFtDKaYO9IkyAaZwM6tgPCESvLBQ=; b=r7hsVGvabgqC1UurdT3UQ30TN/DPyVIWBhv/R/HSIgN1k074AQQhKJDSQSLh35rP3X 2Zra+VdS+c4qjrKwxr7P9IKjZIt/iWSQ2MBFqNMZBZVl8CP7sFNGvK4OT9Z6l2kuvR6a X3n69pzuJHnEOeKZQROSf/XftLHqG4rMHGYtA6tgeslu5Zo99jSGUh+lZIe41+SF5rGo QScqLoB+ego3KoAOAafI/eMoONJJLqywWhO3XYhDm3Ab1Kgl0FoV3a86XFQsQwuxdAoc Iovvt4DQ0Mt+H1iiSx4H5cKjgqFHbUTi4kYMBHT/QjUQ1/MF/vQAPP6pPGp7cHcRhyqF Q0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=AnpvcgBNouDltbARFtDKaYO9IkyAaZwM6tgPCESvLBQ=; b=mG/mXrAyMyWH2UW4+DP9/b+rWX9/pARYsadAYYKJneczs387etTKPWeWlgegVD3KME YPFMgsVx9tUxY5CMoeh4F2sQAGdxcYg65Nx1N18HPIpzu4wQBja9yh0HW0LIJmwzfK5x AJ8fa+RCrXQsIBFy2HHY5aTuM0Q6xx2HM6vtxse4JlN16gIy6HNrRWXNGGjljJ0gblLZ dSYTQPrKwME/NnG0ePKPDsi6KPY1WZJOCGkalTFj2IkGYYaN+KOzU6N9JpdHqrinMQE9 fWvPc/Dij5J84qpoKIar6/Mh+9B0PlIv/9KZAhIyxrvWWpMV869TRLZw38gbDf61y/NY TT9w== X-Gm-Message-State: AIVw1136++3bzOyWIy9GbKbDhd41bKQcT+RWd/B8epliJdpUM88jn1YQ DJb2nqswiz5hJ94zHTniz716p4TJApsC X-Received: by 10.107.25.204 with SMTP id 195mr965952ioz.250.1502119314344; Mon, 07 Aug 2017 08:21:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.36.208 with HTTP; Mon, 7 Aug 2017 08:21:53 -0700 (PDT) In-Reply-To: References: From: Tom Bentley Date: Mon, 7 Aug 2017 16:21:53 +0100 Message-ID: Subject: Re: [DISCUSS] KIP-183 - Change PreferredReplicaLeaderElectionCommand to use AdminClient To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="001a113fd7422451f405562b68da" archived-at: Mon, 07 Aug 2017 15:22:02 -0000 --001a113fd7422451f405562b68da Content-Type: text/plain; charset="UTF-8" Hi, I've updated this KIP slightly, to clarify a couple of points. One thing in particular that I would like feedback on is what authorization should be required for triggering the election of the preferred leader? Another thing would be whether the request and responses should be grouped by topic name. This would make for smaller messages when triggering elections for multiple partitions of the same topic. I'd be grateful for any feedback you may have. Cheers, Tom On 2 August 2017 at 18:34, Tom Bentley wrote: > In a similar vein to KIP-179 I've created KIP-183 ( > https://cwiki.apache.org/confluence/display/KAFKA/KIP-183+-+Change+ > PreferredReplicaLeaderElectionCommand+to+use+AdminClient) which is about > deprecating the --zookeeper option to kafka-preferred-replica-election.sh > and replacing it with an option which would use a new AdminClient-based API. > > As it stands the KIP is focussed on simply moving the existing > functionality behind the AdminClient. > > I'd be grateful for any feedback people may have on this. > > Thanks, > > Tom > --001a113fd7422451f405562b68da--