kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adyach <...@git.apache.org>
Subject [GitHub] kafka pull request #3671: KAFKA-5723[WIP]: Refactor BrokerApiVersionsCommand...
Date Tue, 15 Aug 2017 14:56:27 GMT
GitHub user adyach opened a pull request:

    https://github.com/apache/kafka/pull/3671

    KAFKA-5723[WIP]: Refactor BrokerApiVersionsCommand to use the new AdminClient

    This PR brings refactoring to new AdminClient java class for BrokerApiVersionsCommand.
The code was not tested, because I just want to make sure, that I am going in the right direction
with the implementation, at the end tests will be in place. There are also no java doc for
the same reasons. I took a look at #3514 to be more consistent with the implementation for
the whole topic of AdminClient refactoring, so I grabbed argparse4j.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adyach/kafka kafka-5723

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3671
    
----
commit cc7b0eb5055ae44467fd41699ca53bf5a91da371
Author: Andrey Dyachkov <andrey.dyachkov@gmail.com>
Date:   2017-08-14T20:46:27Z

    kafka-5723: preparation phase

commit 8c2864cfda8e12db836de98ed7a59047f2311f85
Author: Andrey Dyachkov <andrey.dyachkov@gmail.com>
Date:   2017-08-15T14:43:07Z

    kafka-5723: draft impl for ListBrokersVersionInfo command

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message