kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From baluchicken <...@git.apache.org>
Subject [GitHub] kafka pull request #3637: KAFKA-4879 KafkaConsumer.position may hang forever...
Date Mon, 07 Aug 2017 15:04:46 GMT
GitHub user baluchicken opened a pull request:

    https://github.com/apache/kafka/pull/3637

    KAFKA-4879 KafkaConsumer.position may hang forever when deleting a topic

    @guozhangwang  I created this PR but it lacks the test. I also has the test but I wanted
to ask which Test file should be the best candidate for this?
    Also there is a TODO line which I created because that method already has a timeout parameter,
what do you think how can we proceed there?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/baluchicken/kafka-1 KAFKA-4879

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3637.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3637
    
----
commit 211b2118b0ec5fd7ff5b499ef17c92b0d31e76e3
Author: Balint Molnar <balintmolnar91@gmail.com>
Date:   2017-08-07T14:54:34Z

    KAFKA-4879 KafkaConsumer.position may hang forever when deleting a topic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message