kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jun Rao <...@confluent.io>
Subject Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL
Date Thu, 31 Aug 2017 17:10:04 GMT
That's also fine as long as it's documented in the interface somehow. The
only thing with java Closeable is that it throws IOException. In most of
our usage, we use close() with no exception since it's not clear what you
will do when an exception is thrown in close().

Thanks,

Jun

On Thu, Aug 31, 2017 at 10:02 AM, Jason Gustafson <jason@confluent.io>
wrote:

> Hey Jun,
>
> I will add a note to the KIP, but my plan was to dynamically check whether
> the KafkaPrincipalBuilder implemented Configurable or Closeable. That makes
> implementing close() and configure() optional. Does that seem reasonable?
>
> -Jason
>
> On Thu, Aug 31, 2017 at 9:53 AM, Jun Rao <jun@confluent.io> wrote:
>
> > Hi, Jason,
> >
> > Thanks for the KIP. +1. Just one minor comment. It seems that the new
> > KafkaPrincipalBuilder
> > interface should support Configurable and close() as the existing
> > PrincipalBuilder?
> >
> > Jun
> >
> > On Wed, Aug 30, 2017 at 8:51 AM, Jason Gustafson <jason@confluent.io>
> > wrote:
> >
> > > I'd like to open the vote for KIP-189:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL.
> > > Thanks to everyone who helped review.
> > >
> > > -Jason
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message