kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5437) TransactionalMessageCopier should be force killed on test shutdown
Date Mon, 12 Jun 2017 22:55:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047171#comment-16047171
] 

ASF GitHub Bot commented on KAFKA-5437:
---------------------------------------

GitHub user apurvam opened a pull request:

    https://github.com/apache/kafka/pull/3308

    KAFKA-5437: Always send a sig_kill when cleaning the message copier

    When the message copier hangs (like when there is a bug in the client), it ignores the
sigterm and doesn't shut down. this leaves the cluster in an unclean state causing future
tests to fail. 
    
    In this patch we always send SIGKILL when cleaning the node if the process isn't already
dead. This is consistent with the other services.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apurvam/kafka KAFKA-5437-force-kill-message-copier-on-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3308
    
----
commit 5364c4830f5f97fbbfbefbf2c92e1d7230490ebf
Author: Apurva Mehta <apurva@confluent.io>
Date:   2017-06-12T22:52:45Z

    Always send a sig_kill when cleaning the message copier

----


> TransactionalMessageCopier should be force killed on test shutdown
> ------------------------------------------------------------------
>
>                 Key: KAFKA-5437
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5437
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, core, producer 
>            Reporter: Jason Gustafson
>            Assignee: Apurva Mehta
>             Fix For: 0.11.1.0
>
>
> We've seen a few cases of the transactional message copier service failing to be shutdown
properly in a test case. We should probabl kill -9 in {{clean_node}} like we do with some
of the other services.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message