kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Bejeck <bbej...@gmail.com>
Subject Re: [DISCUSS] KIP-167: Add interface for the state store restoration process
Date Fri, 30 Jun 2017 15:27:05 GMT
Damian,

Thanks for comments.  I've updated the KIP with the abstract classes.

Thanks,
Bill

On Fri, Jun 30, 2017 at 9:57 AM, Damian Guy <damian.guy@gmail.com> wrote:

> Thanks for the updated KIP Bill.
>
> In the PR you have AbstractBatchingRestoreCallback and
> AbstractNotifyingRestoreCallback which are both in public packages, so are
> part of the API. I think you need to add those to the KIP to round it off.
>
> Otherwise LGTM.
>
> Thanks,
> Damian
>
> On Fri, 30 Jun 2017 at 12:39 Bill Bejeck <bbejeck@gmail.com> wrote:
>
> > Hi,
> >
> > I updated the KIP yesterday and reposted on the original thread, but I
> > think it may get lost in the shuffle.  I'd like to have one more round of
> > discussion on the KIP found here:
> >
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 167%3A+Add+interface+for+the+state+store+restoration+process
> >
> > There's also an initial PR here :
> > https://github.com/apache/kafka/pull/3325
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message