Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Fri, 19 May 2017 19:55:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.13073456.1495205624000.253022.1495223704251@Atlassian.JIRA>
In-Reply-To: <JIRA.13073456.1495205624000@Atlassian.JIRA>
References: <JIRA.13073456.1495205624000@Atlassian.JIRA> <JIRA.13073456.1495205624364@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-5294) PlainSaslServerFactory should allow
 a null Map in getMechanismNames
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 19 May 2017 19:55:10 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-5294?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1601=
7935#comment-16017935 ]=20

ASF GitHub Bot commented on KAFKA-5294:
---------------------------------------

GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/3105

    KAFKA-5294: PlainSaslServerFactory should allow a null Map in getMech=
=E2=80=A6

    =E2=80=A6anismNames
   =20
    If props is null, use POLICY_NOPLAINTEXT default value: false
   =20
    As far as I can tell, none of the other classes implementing SaslServer=
Factory use the properties Map

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-5294

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3105
   =20
----
commit 432c48c3f49ccc3090646671bdba82a2ef05b839
Author: Mickael Maison <mickael.maison@gmail.com>
Date:   2017-05-19T19:38:13Z

    KAFKA-5294: PlainSaslServerFactory should allow a null Map in getMechan=
ismNames
   =20
    If props is null, use POLICY_NOPLAINTEXT default value: false

----


> PlainSaslServerFactory should allow a null Map in getMechanismNames
> -------------------------------------------------------------------
>
>                 Key: KAFKA-5294
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5294
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.2.1
>            Reporter: Bryan Bende
>             Fix For: 0.11.0.0
>
>
> PlainSaslServerFactory will get a NullPointerException if getMechanismNam=
es(Map<String,?> props) is called with a null props map.
> The Java docs for getMechanismNames from the base class javax.security.sa=
sl.SaslServerFactory say that the map can be null:
> * @param props The possibly null set of properties used to specify the
>      * security policy of the SASL mechanisms.
> A scenario where this causes a problem is when attempting to use a Kafka =
consumer/producer with the PlainLoginModule in the same JVM as a Hadoop cli=
ent with Kerberos...
> The Hadoop client purposely calls getMechanismNames with a null map, so i=
f you have already create a Kafka consumer/producer with PlainLoginModule t=
hen the PlainSaslServerFactory will be registered in the list of providers =
in java.security.Security, and then NPEs when the Hadoop client calls getMe=
chanismNames on each provider with a null map.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)