Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
Date: Sat, 20 May 2017 18:30:04 +0000 (UTC)
From: "Jorge Quilcate (JIRA)" <jira@apache.org>
To: dev@kafka.apache.org
Message-ID: <JIRA.13072934.1495055556000.256268.1495305004108@Atlassian.JIRA>
In-Reply-To: <JIRA.13072934.1495055556000@Atlassian.JIRA>
References: <JIRA.13072934.1495055556000@Atlassian.JIRA> <JIRA.13072934.1495055556157@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-5266) Follow-up improvements for consumer
 offset reset tool (KIP-122)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 20 May 2017 18:30:10 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018581#comment-16018581 ] 

Jorge Quilcate commented on KAFKA-5266:
---------------------------------------

I like 'to-current', I'll implement it.

On 4, you're right, NPE is possible in those cases. Wouldn't be better to filter those 'null's and print some warning logs before #toMap? And then catch any other exception on the all #resetOffsets implementation?

> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
>                 Key: KAFKA-5266
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5266
>             Project: Kafka
>          Issue Type: Bug
>          Components: tools
>            Reporter: Jason Gustafson
>            Assignee: Jorge Quilcate
>             Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition. We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the supported reset options are provided. This seems kind of useless. Perhaps we should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are trying to reset. It would be better to raise an exception with a friendlier message.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)