Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CC2ED200C7E for ; Tue, 9 May 2017 00:32:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CAB8C160BBF; Mon, 8 May 2017 22:32:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1DEA1160BA5 for ; Tue, 9 May 2017 00:32:08 +0200 (CEST) Received: (qmail 33235 invoked by uid 500); 8 May 2017 22:32:08 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 33219 invoked by uid 99); 8 May 2017 22:32:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 22:32:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 893A3C030F for ; Mon, 8 May 2017 22:32:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 2PhEGPeYjFHB for ; Mon, 8 May 2017 22:32:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3C91E5FDB7 for ; Mon, 8 May 2017 22:32:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 683B8E0272 for ; Mon, 8 May 2017 22:32:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 59AD821DFA for ; Mon, 8 May 2017 22:32:04 +0000 (UTC) Date: Mon, 8 May 2017 22:32:04 +0000 (UTC) From: "Matthias J. Sax (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-5198) RocksDbStore#openIterators should be synchronized, since it is accessed from multiple threads MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 May 2017 22:32:10 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-5198: ----------------------------------- Component/s: streams > RocksDbStore#openIterators should be synchronized, since it is accessed from multiple threads > --------------------------------------------------------------------------------------------- > > Key: KAFKA-5198 > URL: https://issues.apache.org/jira/browse/KAFKA-5198 > Project: Kafka > Issue Type: Bug > Components: streams > Reporter: Colin P. McCabe > Assignee: Colin P. McCabe > > Currently, {{RocksDBIterator#close}} accesses {{RocksDbStore#openIterators}} without taking the {{RocksDbStore}} lock. The only lock {{RocksDBIterator#close}} holds is a lock on the iterator object, which does not help here. So {{RocksDbStore#openIterators}} should be made synchronized. Otherwise there is undefined behavior, including {{ConcurrentModificationExceptions}}. -- This message was sent by Atlassian JIRA (v6.3.15#6346)