Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 789AE200C72 for ; Fri, 12 May 2017 20:08:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 770C9160BB8; Fri, 12 May 2017 18:08:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BDAE8160BA8 for ; Fri, 12 May 2017 20:08:07 +0200 (CEST) Received: (qmail 63083 invoked by uid 500); 12 May 2017 18:08:06 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 63072 invoked by uid 99); 12 May 2017 18:08:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 May 2017 18:08:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5D4EDC347C for ; Fri, 12 May 2017 18:08:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rsEqoyOTI4CG for ; Fri, 12 May 2017 18:08:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1CC885FC3D for ; Fri, 12 May 2017 18:08:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C824E070C for ; Fri, 12 May 2017 18:08:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 158D4242FD for ; Fri, 12 May 2017 18:08:04 +0000 (UTC) Date: Fri, 12 May 2017 18:08:04 +0000 (UTC) From: "Edoardo Comar (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4982) Add listener tag to socket-server-metrics.connection-... metrics (KIP-136) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 12 May 2017 18:08:08 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008499#comment-16008499 ] Edoardo Comar commented on KAFKA-4982: -------------------------------------- Thanks [~ijuma] following the discussion in the PR thread, I've updated the implementation to only use the listener tag and I've updated the KIP to match the implementation and describe the compatibility choice of not tagging the yammer metric. > Add listener tag to socket-server-metrics.connection-... metrics (KIP-136) > -------------------------------------------------------------------------- > > Key: KAFKA-4982 > URL: https://issues.apache.org/jira/browse/KAFKA-4982 > Project: Kafka > Issue Type: Improvement > Reporter: Edoardo Comar > Assignee: Edoardo Comar > Fix For: 0.11.0.0 > > > Metrics in socket-server-metrics like connection-count connection-close-rate etc are tagged with networkProcessor: > where the id of a network processor is just a numeric integer. > If you have more than one listener (eg PLAINTEXT, SASL_SSL, etc.), the id just keeps incrementing and when looking at the metrics it is hard to match the metric tag to a listener. > You need to know the number of network threads and the order in which the listeners are declared in the brokers' server.properties. > We should add a tag showing the listener label, that would also make it much easier to group the metrics in a tool like grafana -- This message was sent by Atlassian JIRA (v6.3.15#6346)