Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
MIME-Version: 1.0
Sender: ismaelj@gmail.com
In-Reply-To: <CAFc58G9+9nKzz=w7bLDEHyqRgqve8JPyLr6Y_horcoTjaezfeg@mail.gmail.com>
References: <CAD5tkZbT3+bS62hgP9QcY83k1B9K-QRQgbgTnLhE4kKPpgZSuw@mail.gmail.com>
 <CAFc58G9+9nKzz=w7bLDEHyqRgqve8JPyLr6Y_horcoTjaezfeg@mail.gmail.com>
From: Ismael Juma <ismael@juma.me.uk>
Date: Sat, 6 May 2017 02:55:43 +0100
Message-ID: <CAD5tkZZgKV5Cz5p8HZjVZanPykCsv1Y-uukaz-8k+gcP4=bykw@mail.gmail.com>
Subject: Re: [DISCUSS] KIP-133: List and Alter Configs Admin APIs
To: dev@kafka.apache.org
Content-Type: multipart/alternative; boundary=001a11403990376620054ed1504f
archived-at: Sat, 06 May 2017 01:56:36 -0000

--001a11403990376620054ed1504f
Content-Type: text/plain; charset=UTF-8

Hi Jun,

Thanks for the review.

1. Yes, a Set would work too. I updated to take Collection for consistency
as Colin said.
2. That was a typo, it should have been a boolean indicating whether we
should only perform validation. Updated the KIP.

Thanks,
Ismael

On Fri, May 5, 2017 at 6:35 PM, Jun Rao <jun@confluent.io> wrote:

> Hi, Ismael,
>
> Thanks for the KIP. Looks good overall. Just a couple of minor comments.
>
> 1. Should AdminClient.listConfigs() take a set of ConfigEntity instead of a
> list?
>
> 2. validateOnly(boolean timeout): Should the time be Integer?
>
> Jun
>
>
> On Thu, May 4, 2017 at 7:32 PM, Ismael Juma <ismael@juma.me.uk> wrote:
>
> > Hi all,
> >
> > We've posted "KIP-133: List and Alter Configs Admin APIs" for discussion:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 133%3A+List+and+Alter+Configs+Admin+APIs
> >
> > This completes the first batch of AdminClient APIs so that topic, config
> > and ACL management is supported.
> >
> > Please take a look. Your feedback is appreciated.
> >
> > Thanks,
> > Ismael
> >
>

--001a11403990376620054ed1504f--