kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From reftel <...@git.apache.org>
Subject [GitHub] kafka pull request #3167: MINOR: Remove unused configuration setting
Date Tue, 30 May 2017 14:07:44 GMT
GitHub user reftel opened a pull request:

    https://github.com/apache/kafka/pull/3167

    MINOR: Remove unused configuration setting

    The configuration setting zookeeper.sync.time.ms was not used for anything.
    Remove it to reduce confusion.
    
    This changes rebalance.backoff.ms from defaulting to the value of zookeeper.sync.time.ms
to default to 2000 (zookeeper.sync.time.ms's default). This means that if someone has not
set rebalance.backoff.ms but has changed zookeeper.sync.time.ms from its default, then rebalance.backoff.ms
will now instead be 2000ms. I'd be surprised if there were users who do this intentionally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reftel/kafka feature/no_zk_sync_time

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3167.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3167
    
----
commit e7672bcd61193bc94a34ebc5368bcf8f510c1fbc
Author: Magnus Reftel <magnus.reftel@skatteetaten.no>
Date:   2017-05-30T12:59:49Z

    MINOR: Remove unused configuration setting
    
    The configuration setting zookeeper.sync.time.ms was not used for anything.
    Remove it to reduce confusion.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message