kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ijuma <...@git.apache.org>
Subject [GitHub] kafka pull request #3046: MINOR: Consolidate Topic classes
Date Sat, 13 May 2017 23:31:48 GMT
GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3046

    MINOR: Consolidate Topic classes

    During the 0.11.0.0 cycle, a Java version of the class
    was introduced so that Streams could use it. Given that
    it includes the bulk of the functionality of the Scala
    version of the class, it makes sense to consolidate them.
    
    While doing this, I noticed that one of the tests for
    the Java class (`shouldThrowOnInvalidTopicNames`) was
    broken as it only checked if the first topic name in
    the list was invalid.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka consolidate-topic-classes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3046.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3046
    
----
commit b4df79664c2b56fc35987ccd34191badfa580c4a
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-05-13T23:28:10Z

    MINOR: Consolidate Topic classes
    
    During the 0.11.0.0 cycle, a Java version of the class
    was introduced so that Streams could use it. Given that
    it includes the bulk of the functionality of the Scala
    version of the class, it makes sense to consolidate them.
    
    While doing this, I noticed that one of the tests for
    the Java class (`shouldThrowOnInvalidTopicNames`) was
    broken as it only checked if the first topic name in
    the list was invalid.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message