kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ijuma <...@git.apache.org>
Subject [GitHub] kafka pull request #3031: MINOR: Fix bug in `waitUntilLeaderIsElectedOrChang...
Date Fri, 12 May 2017 09:17:27 GMT
GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3031

    MINOR: Fix bug in `waitUntilLeaderIsElectedOrChanged` and simplify result type

    Also disable a couple of tests that were passing incorrectly until KAFKA-3096 is fixed.
    
    The bug was for the following case:
    
    `leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined &&
newLeaderOpt.get != leader.get`
    
    We would consider it a successful election even though we should not.
    
    I also changed the result type as we never return `None` (we throw an exception instead).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka fix-wait-until-leader-is-elected

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3031
    
----
commit 75a441087f4bbac973afe1198fd382df790552f6
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2016-01-08T16:48:47Z

    MINOR: Fix bug in `waitUntilLeaderIsElectedOrChanged` and simplify result type
    
    Also disable a couple of tests that were passing incorrectly until KAFKA-3096 is fixed.
    
    The bug was for the following case:
    
    `leader.isDefined && oldLeaderOpt.isEmpty && newLeaderOpt.isDefined &&
newLeaderOpt.get != leader.get`
    
    We would consider it a successful election even though we should not.
    
    I also changed the result type as we never return `None` (we throw an exception instead).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message