kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5340) Add additional test cases for batch splitting to ensure idempotent/transactional metadata is preserved
Date Mon, 29 May 2017 03:30:04 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028019#comment-16028019
] 

ASF GitHub Bot commented on KAFKA-5340:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/3162

    KAFKA-5340: Batch splitting should preserve magic and transactional flag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-5340

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3162
    
----
commit 8881e16f5d690e3cc107786d08d6ad39cb4d2b14
Author: Jason Gustafson <jason@confluent.io>
Date:   2017-05-29T03:27:59Z

    KAFKA-5340: Batch splitting should preserve magic and transactional flag

----


> Add additional test cases for batch splitting to ensure idempotent/transactional metadata
is preserved
> ------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5340
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5340
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: clients, core, producer 
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.11.0.0
>
>
> We noticed in the patch for KAFKA-5316 that the transactional flag was not being preserved
after batch splitting. We should make sure that we have all the cases covered in unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message