kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin P. McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5275) Review and potentially tweak AdminClient API for the initial release (KIP-117)
Date Fri, 19 May 2017 16:36:05 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017629#comment-16017629
] 

Colin P. McCabe commented on KAFKA-5275:
----------------------------------------

bq. It'd be great to simplify the creation of the NewTopic objects. As part of the PR for
KIP-154 / KAFKA-4667 I added a builder for NewTopic that has methods to set replication factor,
num partitions, the cleanup policy (currently compacted only), min ISRs, etc. It's currently
an implementation detail of Kafka Connect, but it'd be great if that could move down to the
AdminClient.

Yeah, I think it makes sense to consider adding this to `AdminClient`.

[~xvrl] also proposed adding a comment to the {{AdminClient}} JavaDoc discussing the existence
of the {{AdminClientConfig}} class, which might not be clear for first-time users.

> Review and potentially tweak AdminClient API for the initial release (KIP-117)
> ------------------------------------------------------------------------------
>
>                 Key: KAFKA-5275
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5275
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.11.0.0
>
>
> Once all the pieces are in, we should take a pass and ensure that the APIs work well
together and that they are consistent.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message