kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5194) KIP-153 : Include only client traffic in BytesOutPerSec metric
Date Tue, 09 May 2017 14:05:04 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002730#comment-16002730
] 

ASF GitHub Bot commented on KAFKA-5194:
---------------------------------------

GitHub user mimaison opened a pull request:

    https://github.com/apache/kafka/pull/3003

    KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec me…

    …tric
    
    Also added 2 new metrics to account for incoming/outgoing traffic due to internal replication
    - ReplicationBytesInPerSec
    - ReplicationBytesOutPerSec
    
    We had a look at creating an integration test to verify the Bytes/Replication In/Out metrics
but had issues.
    When running using IntegrationTestHarness, all the brokers were using the same Yammer
Metrics registry and metrics name collided. 
    
    Also although we only update the global value for the 2 new metrics, we can see an inner
node for each topic (that stays 0).
    eg: kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesOutPerSec,topic=testtopic
    
     It looks like something forced by BrokerTopicMetrics. If there's no way to remove them,
then we might want to update them accordingly to give them meaningful values

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mimaison/kafka KAFKA-5194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3003
    
----
commit ce34c59e80d3ecd6d0473b2867b839da5edd1bb6
Author: Mickael Maison <mickael.maison@gmail.com>
Date:   2017-05-08T16:44:51Z

    KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec metric
    
    Also added 2 new metrics to account for incoming/outgoing traffic due to internal replication
    - ReplicationBytesInPerSec
    - ReplicationBytesOutPerSec

----


> KIP-153 : Include only client traffic in BytesOutPerSec metric
> --------------------------------------------------------------
>
>                 Key: KAFKA-5194
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5194
>             Project: Kafka
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Mickael Maison
>            Assignee: Mickael Maison
>             Fix For: 0.11.0.0
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-153+%3A+Include+only+client+traffic+in+BytesOutPerSec+metric



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message