kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edoardo Comar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4982) Add listener tag to socket-server-metrics.connection-... metrics (KIP-136)
Date Fri, 12 May 2017 18:08:04 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008499#comment-16008499
] 

Edoardo Comar commented on KAFKA-4982:
--------------------------------------

Thanks [~ijuma] following the discussion in the PR thread, I've updated the implementation
to only use the listener tag
and I've updated the KIP to match the implementation and describe the compatibility choice
of not tagging the yammer metric.



> Add listener tag to socket-server-metrics.connection-... metrics (KIP-136)
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-4982
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4982
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Edoardo Comar
>            Assignee: Edoardo Comar
>             Fix For: 0.11.0.0
>
>
> Metrics in socket-server-metrics like connection-count connection-close-rate etc are
tagged with networkProcessor:<id>
> where the id of a network processor is just a numeric integer.
> If you have more than one listener (eg PLAINTEXT, SASL_SSL, etc.), the id just keeps
incrementing and when looking at the metrics it is hard to match the metric tag to a listener.

> You need to know the number of network threads and the order in which the listeners are
declared in the brokers' server.properties.
> We should add a tag showing the listener label, that would also make it much easier to
group the metrics in a tool like grafana



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message