kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismael Juma <ism...@juma.me.uk>
Subject Re: [DISCUSS] KIP-143: Controller Health Metrics
Date Thu, 04 May 2017 12:23:25 GMT
Hi Joel,

Thanks for the feedback. Comments inline.

On Wed, May 3, 2017 at 7:52 PM, Joel Koshy <jjkoshy.w@gmail.com> wrote:

> Yes - that is roughly what I was thinking (although deletes are no longer
> long running). Also, what is the "steady-state" controller state? Idle?
>

Yes.


> What about a broker that is not the controller? Would you need a separate
> idle-not-controller state?


Do we need a separate state or can users just use the ActiveControllerCount
metric to check if the broker is the controller?


> Given that most of the state changes are short
> we would just see blips in the best case and nothing in the worst case
> (depending on how often metrics get sampled). It would only help if you
> want to visually detect any transitions that are taking an inordinate
> duration.
>

Right. Do you think this is not worth it?

Ok - my thought was since we are already using kafka-metrics for quotas and
> selector metrics we could just do the same for this (and any *new* metrics
> on the broker).
>

I don't have a strong opinion either way as I think both options have pros
and cons. It seems like we don't have the concept of a Gauge in Kafka
Metrics at the moment, so it seems like it would be easier to do it via
Yammer metrics while we discuss what's the best way to unify all the
metrics again.

Thanks,
Ismael

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message