Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kafka.apache.org
From: Ashish <ashishleo25@gmail.com>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-FBEE54BD-6E6A-410A-8795-64EFF5894C6C
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Date: Fri, 28 Apr 2017 20:40:40 +0530
Subject: Re: [jira] [Commented] (KAFKA-4379) Remove caching of dirty and removedkeys from StoreChangeLogger
Message-Id: <0280A67B-578B-4F8F-847D-06C2264E7850@gmail.com>
References: <JIRA.13018043.1478260074000@Atlassian.JIRA> <JIRA.13018043.1478260074023@jira-lw-us.apache.org> <1493096559187.1316628015@boxbe>
In-Reply-To: <1493096559187.1316628015@boxbe>
To: dev@kafka.apache.org
archived-at: Fri, 28 Apr 2017 15:10:54 -0000

--Apple-Mail-FBEE54BD-6E6A-410A-8795-64EFF5894C6C
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable

Bc

Sent from my iPhone
B
> On 25-Apr-2017, at 10:21, ASF GitHub Bot (JIRA) <jira@apache.org> wrote:
>=20
>    This message is eligible for Automatic Cleanup! (jira@apache.org) Add c=
leanup rule | More info=20
>=20
>    [ https://issues.apache.org/jira/browse/KAFKA-4379?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15982=
362#comment-15982362 ]=20
>=20
> ASF GitHub Bot commented on KAFKA-4379:
> ---------------------------------------
>=20
> GitHub user guozhangwang opened a pull request:
>=20
>    https://github.com/apache/kafka/pull/2908
>=20
>    KAFKA-4379 Followup: Remove eviction listener from InMemoryLRUCache
>=20
>=20
>=20
> You can merge this pull request into a Git repository by running:
>=20
>    $ git pull https://github.com/guozhangwang/kafka K4379-remove-listener
>=20
> Alternatively you can review and apply these changes as the patch at:
>=20
>    https://github.com/apache/kafka/pull/2908.patch
>=20
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>=20

>    This closesv #2908
>=20
> ----
> commit 44e1cea3a300b0e05e9574284260b774b852cb4e
> Author: Guozhang Wang <wangguoz@gmail.com>
> Date:   2017-04-25T02:07:23Z
>=20
>    remove eviction listener
> C
> commit 6343783ec2ffc907ad2b1d25cd764a6e52acc299
> Author: Guozhang Wang <wangguoz@gmail.comem yz
> Date:   2017-04-25T04:50:02Z
>=20
>    fix unit test
>=20
> ----
>=20
>=20
>> Remove caching of dirty and removed keys from StoreChangeLoggerpc
>> ---------------------------------------------------------------
>>=20
>>                Key: KAFKA-4379
>>                URL: https://issues.apache.org/jira/browse/KAFKA-4379
>>            Project: Kafka
>>         Issue Type: Improvement
>>         Components: streams
>>   Affects Versions: 0.10.1.0
>>           Reporter: Damian Guy
>>           Assignee: Damian Guy
>>           Priority: Minor
>>            Fix For: 0.10.1.1, 0.10.2.0
>>=20
>>=20
>> The StoreChangeLogger currently keeps a cache of dirty and removed keys a=
nd will batch the changelog records such that we don't send a record for eac=
h update. However, with KIP-63 this is unnecessary as the batching and de-du=
ping is done by the caching layer. Further, the StoreChangeLogger relies on c=
ontext.timestamp() which is likely to be incorrect when caching is enabled
>=20
>=20
>=20
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)

--Apple-Mail-FBEE54BD-6E6A-410A-8795-64EFF5894C6C--