kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mihbor <...@git.apache.org>
Subject [GitHub] kafka pull request #2948: KAFKA-5144 renamed and added comments to make it c...
Date Sun, 30 Apr 2017 18:38:11 GMT
GitHub user mihbor opened a pull request:

    https://github.com/apache/kafka/pull/2948

    KAFKA-5144 renamed and added comments to make it clear what's going on

    The descendingSubsequence is a misnomer. The linked list is actually arranged so that
the lowest timestamp is first and larger timestamps are added to the end, therefore renamed
to ascendingSubsequence.
    The minElem variable was also misnamed. It's actually the current maximum element as it's
taken from the end of the list.
    Added comment to get() to make it clear it's returning the lowest timestamp.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mihbor/kafka patch-4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2948
    
----
commit c8d5f4646e412917495f720102774e450ae06265
Author: mihbor <mihbor@users.noreply.github.com>
Date:   2017-04-30T18:36:08Z

    KAFKA-5144 rename variables and add comments to make it clear what's going on
    
    The descendingSubsequence is a misnomer. The linked list is actually arranged so that
the lowest timestamp is first and larger timestamps are added to the end, therefore renamed
to ascendingSubsequence.
    The minElem variable was also misnamed. It's actually the current maximum element as it's
taken from the end of the list.
    Added comment to get() to make it clear it's returning the lowest timestamp.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message