kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-5096) Only log invalid user configs and overwrite with correct one
Date Thu, 20 Apr 2017 18:17:04 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias J. Sax updated KAFKA-5096:
-----------------------------------
    Description: 
Streams does not allow to overwrite some config parameters (eg, {{enable.auto.commit}}) Currently,
we throw an exception, but this is actually not required, as Streams can just ignore/overwrite
the user provided value.

Thus, instead of throwing, we should just log a WARN message and overwrite the config with
the values that suits Streams. (atm it's only one parameter {{enable.auto.commit}}), but with
exactly-once it's going to be more (cf. KAFKA-4923). Thus, the scope of this ticket depends
when it will be implemented (ie, before or after KAFKA-4923).

This ticket should also include JavaDoc updates that explain what parameters cannot be specified
by the user.

  was:
Streams does not allow to overwrite some config parameters (eg, {{enable.auto.commit}}).

Currently, those checks are done when the consumer/producer config is generated, ie, when
the consumer/producer in instantiated. This means, the check is done quite later after {{KafkaStreams#start()}}
was called.

It would be a better user experience, to check user provided configs early on, ie, in the
constructor of {{StreamsConfig}}.


> Only log invalid user configs and overwrite with correct one
> ------------------------------------------------------------
>
>                 Key: KAFKA-5096
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5096
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Mariam John
>            Priority: Minor
>              Labels: beginner, newbie
>
> Streams does not allow to overwrite some config parameters (eg, {{enable.auto.commit}})
Currently, we throw an exception, but this is actually not required, as Streams can just ignore/overwrite
the user provided value.
> Thus, instead of throwing, we should just log a WARN message and overwrite the config
with the values that suits Streams. (atm it's only one parameter {{enable.auto.commit}}),
but with exactly-once it's going to be more (cf. KAFKA-4923). Thus, the scope of this ticket
depends when it will be implemented (ie, before or after KAFKA-4923).
> This ticket should also include JavaDoc updates that explain what parameters cannot be
specified by the user.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message