kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5096) Only log invalid user configs and overwrite with correct one
Date Fri, 28 Apr 2017 19:39:04 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989348#comment-15989348
] 

ASF GitHub Bot commented on KAFKA-5096:
---------------------------------------

GitHub user johnma14 opened a pull request:

    https://github.com/apache/kafka/pull/2938

    KAFKA-5096: Log invalid user configs and use defaults

    Kafka Streams do not allow users to modify some consumer configurations.
    If the user modifies this property, currently an exception is thrown.
    The following changes were made in this patch:
    - Defined a new array 'NON_CONFIGURABLE_CONSUMER_CONFIGS' to hold the names
      of the configuration parameters that is not allowed to be modified. Currently, this
      contains just 1 parameter - enable_auto_commit. When the 'exactly once'
      feature is implemented ( KAFKA-4923), more parameters can be added to this
      array.
    - Defined a new method 'checkIfUnexpectedUserSpecifiedConsumerConfig' to
      check if user overwrote the values of any of the non configurable configuration
      parameters. If so, then log a warning message and reset the default values
    - Updated the javadoc to include the configuration parameters that cannot be
      modified by users.
    - Updated the corresponding tests in StreamsConfigTest.java to reflect the changes
      made in StreamsConfig.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnma14/kafka bug/kafka-5096

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2938
    
----
commit 1194fab4c3529cb3745548711a39cf9ec8753f04
Author: Mariam John <mariamj@us.ibm.com>
Date:   2017-04-28T18:32:54Z

    KAFKA-5096: Log invalid user configs and use defaults
    
    Kafka Streams do not allow users to modify some consumer configurations.
    Currently, it does not allow modifying the value of 'enable_auto_commit'.
    If the user modifies this property, currently an exception is thrown.
    The following changes were made in this patch:
    - Defined a new array 'NON_CONFIGURABLE_CONSUMER_CONFIGS' to hold the names
      of the configuration parameters that is not allowed to be modified
    - Defined a new method 'checkIfUnexpectedUserSpecifiedConsumerConfig' to
      check if user overwrote the values of any of the non configurable configuration
      parameters. If so, then log a warning message and reset the default values
    - Updated the javadoc to include the configuration parameters that cannot be
      modified by users.
    - Updated the corresponding tests in StreamsConfigTest.java to reflect the changes
      made in StreamsConfig.java

----


> Only log invalid user configs and overwrite with correct one
> ------------------------------------------------------------
>
>                 Key: KAFKA-5096
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5096
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Mariam John
>            Priority: Minor
>              Labels: beginner, newbie
>
> Streams does not allow to overwrite some config parameters (eg, {{enable.auto.commit}})
Currently, we throw an exception, but this is actually not required, as Streams can just ignore/overwrite
the user provided value.
> Thus, instead of throwing, we should just log a WARN message and overwrite the config
with the values that suits Streams. (atm it's only one parameter {{enable.auto.commit}}),
but with exactly-once it's going to be more (cf. KAFKA-4923). Thus, the scope of this ticket
depends when it will be implemented (ie, before or after KAFKA-4923).
> This ticket should also include JavaDoc updates that explain what parameters cannot be
specified by the user.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message