kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tommy Becker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5042) InFlightRequests#isEmpty() always returns false
Date Fri, 07 Apr 2017 22:47:42 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961534#comment-15961534
] 

Tommy Becker commented on KAFKA-5042:
-------------------------------------

Apologies, I used the wrong issue number. Will close the above PR and open again properly.

> InFlightRequests#isEmpty() always returns false
> -----------------------------------------------
>
>                 Key: KAFKA-5042
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5042
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>            Reporter: Tommy Becker
>            Assignee: Ismael Juma
>             Fix For: 0.11.0.0
>
>
> While perusing the NetworkClient code I came across the following: InFlightRequests#isEmpty()
always returns false.
> {code}
>     public boolean isEmpty() {
>         for (Deque<NetworkClient.InFlightRequest> deque : this.requests.values())
{
>             if (!deque.isEmpty())
>                 return false;
>         }
>         return false;
>     }
> {code}
> This method looks like a recent addtion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message