kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "james chien (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KAFKA-4772) Exploit #peek to implement #print() and other methods
Date Sat, 29 Apr 2017 03:33:04 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989732#comment-15989732
] 

james chien edited comment on KAFKA-4772 at 4/29/17 3:32 AM:
-------------------------------------------------------------

I think I got it, this JIRA is about replacing {{`KeyValuePrinter `}}  and {`KStreamForeach`}
with {`KStreamPeek `}, which means wanted to implements like `KStreamImpl#foreach()` with
{`KStreamPeek`} but not {`KStreamForeach`}.


was (Author: james.c):
I think I got it, this JIRA is about replacing {`KeyValuePrinter `}  and {`KStreamForeach`}
with {`KStreamPeek `}, which means wanted to implements like `KStreamImpl#foreach()` with
{`KStreamPeek`} but not {`KStreamForeach`}.

> Exploit #peek to implement #print() and other methods
> -----------------------------------------------------
>
>                 Key: KAFKA-4772
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4772
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: james chien
>            Priority: Minor
>              Labels: beginner, newbie
>
> From: https://github.com/apache/kafka/pull/2493#pullrequestreview-22157555
> Things that I can think of:
> - print / writeAsTest can be a special impl of peek; KStreamPrint etc can be removed.
> - consider collapse KStreamPeek with KStreamForeach with a flag parameter indicating
if the acted key-value pair should still be forwarded.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message