Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 978DD200C3F for ; Wed, 22 Mar 2017 15:13:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 96190160B91; Wed, 22 Mar 2017 14:13:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DB327160B83 for ; Wed, 22 Mar 2017 15:13:44 +0100 (CET) Received: (qmail 26900 invoked by uid 500); 22 Mar 2017 14:13:43 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 26889 invoked by uid 99); 22 Mar 2017 14:13:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Mar 2017 14:13:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7D5F81A0264 for ; Wed, 22 Mar 2017 14:13:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.549 X-Spam-Level: X-Spam-Status: No, score=-98.549 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3LQeC50Exg-E for ; Wed, 22 Mar 2017 14:13:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 856FF5FDA9 for ; Wed, 22 Mar 2017 14:13:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0529E05AE for ; Wed, 22 Mar 2017 14:13:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9922324D33 for ; Wed, 22 Mar 2017 14:13:41 +0000 (UTC) Date: Wed, 22 Mar 2017 14:13:41 +0000 (UTC) From: "Gwen Shapira (JIRA)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4930) Connect Rest API allows creating connectors with an empty name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 22 Mar 2017 14:13:45 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4930?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1593= 6374#comment-15936374 ]=20 Gwen Shapira commented on KAFKA-4930: ------------------------------------- Good catch! If you fix this, we'll gladly take the PR. Let me know if you n= eed help or pointers. > Connect Rest API allows creating connectors with an empty name > -------------------------------------------------------------- > > Key: KAFKA-4930 > URL: https://issues.apache.org/jira/browse/KAFKA-4930 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect > Affects Versions: 0.10.2.0 > Reporter: S=C3=B6nke Liebau > Priority: Minor > > The Connect Rest API allows to deploy connectors with an empty name field= , which then cannot be removed through the api. > Sending the following request: > {code} > { > "name": "", > "config": { > "connector.class": "org.apache.kafka.connect.tools.MockSourceConn= ector", > "tasks.max": "1", > "topics": "test-topic" > =20 > } > } > {code} > Results in a connector being deployed which can be seen in the list of co= nnectors: > {code} > [ > =09"", > =09"testconnector" > ]{code} > But cannot be removed via a DELETE call, as the api thinks we are trying = to delete the /connectors endpoint and declines the request. > I don't think there is a valid case for the connector name to be empty so= perhaps we should add a check for this. I am happy to work on this. -- This message was sent by Atlassian JIRA (v6.3.15#6346)