kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From backender <...@git.apache.org>
Subject [GitHub] kafka pull request #2669: KAFKA-4772: [WIP] Use peek to implement print
Date Fri, 10 Mar 2017 14:36:25 GMT
GitHub user backender opened a pull request:

    https://github.com/apache/kafka/pull/2669

    KAFKA-4772: [WIP] Use peek to implement print

    **PROPOSAL/DISCUSSION FOR KIP-132.**
    Tackles [KAFKA-4772](https://issues.apache.org/jira/browse/KAFKA-4772) and [KAFKA-4830](https://issues.apache.org/jira/browse/KAFKA-4830).
    
    The functionaliy of KeyValuePrinter is replaced with a printAction that
    is being passed to KStreamPeek. We therefore can get rid of
    KeyValuePrinter.
    
    KStream.print was extended to handle KeyValueMapper in order to provide
    users the option to change output of K and V. Therefore, constructors of
    KeyValuePrinter as well as KeyValuePrinterProcessor have to be adapted. The default case
    where no mapper will be passed, is still covered by the previous comma
    separated out of K, V.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/delftswa2017/kafka fix-kafka-4772-4830

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2669
    
----
commit cfa86a243c0d0785ff00bfe9fc3950180406c65f
Author: Marc Juchli <mail@marcjuch.li>
Date:   2017-03-10T14:28:04Z

    Use peek to implement print
    
    The functionaliy of KeyValuePrinter is replaced with a printAction that
    is being passed to KStreamPeek. We therefore can get rid of
    KeyValuePrinter.
    
    KStream.print was extended to handle KeyValueMapper in order to provide
    users the option to change output of K and V. Therefore, constructors of
    KeyValuePrinter as well as KeyValuePrinterProcessor have to be adapted. The default case
    where no mapper will be passed, is still covered by the previous comma
    separated out of K, V.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message