kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cvaliente <...@git.apache.org>
Subject [GitHub] kafka pull request #2621: KAFKA-4800: Streams State transition ASCII diagram...
Date Wed, 01 Mar 2017 11:23:48 GMT
GitHub user cvaliente opened a pull request:

    https://github.com/apache/kafka/pull/2621

    KAFKA-4800: Streams State transition ASCII diagrams need fixing and polishing

    added <pre> tags to not break javadoc display of the ASCII diagrams.
    see broken ascii here:
    https://kafka.apache.org/0102/javadoc/org/apache/kafka/streams/KafkaStreams.State.html
    
    fix can be checked with gradle :streams:javadoc and then checking streams/build/docs/javadoc/org/apache/kafka/streams/KafkaStreams.State.html
    
    I also fixed the diagram in StreamThread.java however currently no javadoc is generated
for that one (since it's internal)
    
    @enothereska please have a look

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvaliente/kafka KAFKA-4800-ASCII-diagrams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2621
    
----
commit 88e83d4633b782f8554f5d3b871e703c0a580657
Author: Clemens Valiente <clemens.valiente@trivago.com>
Date:   2017-03-01T10:47:21Z

    KAFKA-4800 fix display and transitions of ASCII diagrams

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message