kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edoardo Comar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4981) Add connection-accept-rate and connection-prepare-rate metrics
Date Thu, 30 Mar 2017 14:51:42 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949221#comment-15949221
] 

Edoardo Comar commented on KAFKA-4981:
--------------------------------------

as per comments on the pull request, the 'prepared' metric may be better called 'authenticated'
and will have a 0 flat rate for PLAINTEXT listeners.

[~rsivaram] wrote:
Prepared doesn't convey much meaning in terms of an externally visible metric. I imagine you
chose it rather than authenticated since you intended it to work for PLAINTEXT. But PLAINTEXT
doesn't go through this if-block since channel.ready() returns true.


> Add connection-accept-rate and connection-prepare-rate  metrics
> ---------------------------------------------------------------
>
>                 Key: KAFKA-4981
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4981
>             Project: Kafka
>          Issue Type: Improvement
>          Components: network
>            Reporter: Edoardo Comar
>            Assignee: Edoardo Comar
>
> The current set of socket-server-metrics include 
> connection-close-rate and connection-creation-rate.
> On the server-side we'd find useful to have rates for 
> connections accepted and connections 'prepared' (when the channel is ready) 
> to see how many clients do not go through handshake or authentication



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message