kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4907) compacted topic shouldn't reject messages with old timestamp
Date Sun, 19 Mar 2017 06:12:42 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931590#comment-15931590
] 

ASF GitHub Bot commented on KAFKA-4907:
---------------------------------------

GitHub user becketqin opened a pull request:

    https://github.com/apache/kafka/pull/2705

    KAFKA-4907: message.timestamp.difference.max.ms should not be applied to log compacted
topic if user did not set the property.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/becketqin/kafka KAFKA-4907

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2705
    
----
commit 96e1301338619b7d45d5b90adf0cecbf40491a2c
Author: Jiangjie Qin <becket.qin@gmail.com>
Date:   2017-03-19T06:11:19Z

    KAFKA-4907: message.timestamp.difference.max.ms should not be applied to log compacted
topic if user did not set the property.

----


> compacted topic shouldn't reject messages with old timestamp
> ------------------------------------------------------------
>
>                 Key: KAFKA-4907
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4907
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.0
>            Reporter: Jun Rao
>            Assignee: Jiangjie Qin
>
> In LogValidator.validateTimestamp(), we check the validity of the timestamp in the message
without checking whether the topic is compacted or not. This can cause messages to a compacted
topic to be rejected when it shouldn't.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message